[node] Add missing constants to node:constants, add missing dlopen types to v18
#71986
Conversation
Renegade334
force-pushed
the
node-constants
branch
from
1a98da0 to
ace713a
Compare
Renegade334
requested review from
eps1lon and
peterblazejewicz
as code owners
|
@Renegade334 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71986,
"author": "Renegade334",
"headCommitOid": "ace713a7a0073bba30595495051bc8184969fca8",
"mergeBaseOid": "0b32fa9afac119291faf6ca0dc1ccdcb1b120a6e",
"lastPushDate": "2025-02-19T20:28:06.000Z",
"lastActivityDate": "2025-03-08T06:36:02.000Z",
"mergeOfferDate": "2025-03-07T22:46:10.000Z",
"mergeRequestDate": "2025-03-08T06:36:02.000Z",
"mergeRequestUser": "Renegade334",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/constants.ts",
"kind": "test"
},
{
"path": "types/node/v18/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/constants.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/process.ts",
"kind": "test"
},
{
"path": "types/node/v20/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/constants.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2025-03-07T22:45:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2670611556,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Unreviewed
|
Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
Maintainer Approved
Self Merge
|
@Renegade334: Everything looks good here. I am ready to merge this PR (at ace713a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge. |
node:constantsis deprecated, but the types may as well be correct. Adds the missing dlopen constants to the module, and reduces the test burden.This also revealed that the types for dlopen, which has existed since v0, were missed from previous branches when they were added to @types/node during the v20 cycle. Backports these to v18.
pnpm test <package to test>.If changing an existing definition:
package.json.