Update return type of ScriptOptions.importModuleDynamically #71912
Conversation
When the importModuleDynamically is a function, it should be an `async` function instead of an `async` one as shown in this example https://nodejs.org/docs/latest-v22.x/api/vm.html#when-importmoduledynamically-is-a-function. However, the docs and its types definitions are not up-to-date.
rhumbertgz
requested review from
eps1lon and
peterblazejewicz
as code owners
|
@rhumbertgz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71912,
"author": "rhumbertgz",
"headCommitOid": "4c3b894058cb53e497ed782ed6de9a7ec588c6ab",
"mergeBaseOid": "36f851c86a080a406b8d5dc8e95880363d16083b",
"lastPushDate": "2025-02-11T08:37:56.000Z",
"lastActivityDate": "2025-02-13T01:56:40.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/vm.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "Renegade334",
"date": "2025-02-13T01:56:40.000Z",
"abbrOid": "826eaf0"
}
],
"mainBotCommentID": 2650734557,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Revision needed
|
@rhumbertgz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Add support for both Module and Promise<Module> as return types for importModuleDynamically Co-authored-by: René <[email protected]>
typescript-bot
removed
the
Revision needed
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
When the importModuleDynamically is a function, it should be an
asyncfunction instead of anasyncone as shown in this example https://nodejs.org/docs/latest-v22.x/api/vm.html#when-importmoduledynamically-is-a-function.However, the docs and its types definitions are not up-to-date.