fix(node): remove unnecessary options from filehandle.writeFile() #71782
Conversation
|
@y-hsgw Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71782,
"author": "y-hsgw",
"headCommitOid": "92fc980dc8dd09981e99b33f62561a450ebd1559",
"mergeBaseOid": "d757e7089fe724d90d85813c1a2ea2e437a13604",
"lastPushDate": "2025-01-29T13:12:57.000Z",
"lastActivityDate": "2025-02-03T23:46:08.000Z",
"mergeOfferDate": "2025-02-03T18:02:36.000Z",
"mergeRequestDate": "2025-02-03T23:46:08.000Z",
"mergeRequestUser": "y-hsgw",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v16/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v18/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v20/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/fs.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2025-02-03T18:01:58.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "Renegade334",
"date": "2025-01-30T12:33:41.000Z",
"abbrOid": "03f9dba"
}
],
"mainBotCommentID": 2621624163,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Does this need to be applied to older versions? |
|
Looks like this behaviour goes back to v14, so ideally. |
typescript-bot
added
the
Where is GH Actions?
|
I've also tried applying the older versions. |
typescript-bot
removed
the
Where is GH Actions?
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
typescript-bot
added
Maintainer Approved
Self Merge
|
@y-hsgw: Everything looks good here. I am ready to merge this PR (at 92fc980) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.