fix(node/v18): missing perf_hooks API #71665
Conversation
LukeCarrier
force-pushed
the
node-v18-perf-hooks
branch
from
62f28e0 to
f822c2a
Compare
LukeCarrier
requested review from
eps1lon and
peterblazejewicz
as code owners
|
@LukeCarrier Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71665,
"author": "LukeCarrier",
"headCommitOid": "75867056cea6eb9dac910012686db7187f6cf27a",
"mergeBaseOid": "dde4bd1701da5466a0b2c0279398a7f364b79dc3",
"lastPushDate": "2025-01-16T10:34:49.000Z",
"lastActivityDate": "2025-01-22T23:25:33.000Z",
"mergeOfferDate": "2025-01-22T23:07:59.000Z",
"mergeRequestDate": "2025-01-22T23:25:33.000Z",
"mergeRequestUser": "LukeCarrier",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/v18/perf_hooks.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2025-01-22T23:07:21.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2595255202,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
Hey @LukeCarrier, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
Partial backport of the relevant bits of DefinitelyTyped#69718.
LukeCarrier
force-pushed
the
node-v18-perf-hooks
branch
from
f822c2a to
7586705
Compare
typescript-bot
added
Maintainer Approved
Self Merge
|
@LukeCarrier: Everything looks good here. I am ready to merge this PR (at 7586705) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
Partial backport of the
perf_hooksbits of #69718. No tests were included for this change, so there was nothing to backport.I don't believe I need to update the types package version since it's at
18.19.9999and no types are introduced from a later major version.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.