[node] Update typings to v22.13.0 #71663
Conversation
Renegade334
force-pushed
the
node-22.13.0
branch
4 times, most recently
from
4ef1635 to
98a924a
Compare
Renegade334
force-pushed
the
node-22.13.0
branch
from
98a924a to
848b6d0
Compare
Renegade334
requested review from
eps1lon and
peterblazejewicz
as code owners
|
@Renegade334 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71663,
"author": "Renegade334",
"headCommitOid": "848b6d07f972286373ba200d6b99152c88322d13",
"mergeBaseOid": "ffe46d9382e765fc0f54530b4653e57e6ef0921c",
"lastPushDate": "2025-01-16T09:15:00.000Z",
"lastActivityDate": "2025-01-31T19:41:30.000Z",
"mergeOfferDate": "2025-01-28T19:16:45.000Z",
"mergeRequestDate": "2025-01-31T19:41:30.000Z",
"mergeRequestUser": "Renegade334",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/buffer.buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/sea.d.ts",
"kind": "definition"
},
{
"path": "types/node/sqlite.d.ts",
"kind": "definition"
},
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/test/module.ts",
"kind": "test"
},
{
"path": "types/node/test/net.ts",
"kind": "test"
},
{
"path": "types/node/test/sea.ts",
"kind": "test"
},
{
"path": "types/node/test/sqlite.ts",
"kind": "test"
},
{
"path": "types/node/test/util.ts",
"kind": "test"
},
{
"path": "types/node/util.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2025-01-28T19:16:04.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2619030767,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Unreviewed
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
Maintainer Approved
Self Merge
|
@Renegade334: Everything looks good here. I am ready to merge this PR (at 848b6d0) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge. |
sea.getRawAsset(key)always returns an ArrayBufferfeatures.{ipv6,uv}andfeatures.tls_*StatementSync.prototype.iteratemethoddb.loadExtensionpnpm test <package to test>.If changing an existing definition:
package.json.