fix(node): Socket send accepts Buffer, TypedArray and DataView as input #71659
Conversation
|
@jwetzell Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71659,
"author": "jwetzell",
"headCommitOid": "ea3bd0821e08942e1945f2af833161a5b37813dd",
"mergeBaseOid": "e61ef76ec324fce99648f6306042b59763da9c28",
"lastPushDate": "2025-01-16T01:28:40.000Z",
"lastActivityDate": "2025-01-23T01:31:27.000Z",
"mergeOfferDate": "2025-01-22T22:58:20.000Z",
"mergeRequestDate": "2025-01-23T01:31:27.000Z",
"mergeRequestUser": "jwetzell",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v16/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v18/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v20/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/dgram.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2025-01-22T22:57:41.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "yoursunny",
"date": "2025-01-16T12:17:36.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2594277482,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@jwetzell: Everything looks good here. I am ready to merge this PR (at ea3bd08) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
The
Socket.sendmethod in nodedgramsupportsBuffer,TypedArrayandDataViewnot justUint8ArrayDoc links for versions going back to v16 that this repo covers
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.