[node] Fix module.findSourceMap can return undefined #71216
Conversation
See: - Comment: "@return Returns `module.SourceMap` if a source map is found, `undefined` otherwise." - https://github.com/nodejs/node/pull/44397/files
|
@vicb Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71216,
"author": "vicb",
"headCommitOid": "dc8a4b51dc58aa800132fa4a7ffc5e73dbed3b3a",
"mergeBaseOid": "9d2237e257d53a8d31eb09021e4f1d40cae6b4ef",
"lastPushDate": "2024-11-21T07:40:01.000Z",
"lastActivityDate": "2024-11-23T04:18:44.000Z",
"mergeOfferDate": "2024-11-22T21:46:39.000Z",
"mergeRequestDate": "2024-11-23T04:18:44.000Z",
"mergeRequestUser": "vicb",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v18/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/module.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "anonrig",
"date": "2024-11-22T22:33:33.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-11-22T21:46:01.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "eps1lon",
"date": "2024-11-21T12:52:45.000Z",
"abbrOid": "253b69e"
}
],
"mainBotCommentID": 2490282655,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Owner Approved
typescript-bot
added
the
Other Approved
vicb
changed the title
typescript-bot
removed
Other Approved
|
Added tests for the return type of |
typescript-bot
added
Maintainer Approved
Self Merge
|
@vicb: Everything looks good here. I am ready to merge this PR (at dc8a4b5) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
typescript-bot
added
the
Other Approved
|
@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Thanks for the reviews! Ready to merge |
See:
module.SourceMapif a source map is found,undefinedotherwise."Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.