Skip to content

[node] Add global WebSocket #70166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jul 31, 2024
Merged

[node] Add global WebSocket #70166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions types/node/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ type _RequestInit = typeof globalThis extends { onmessage: any } ? {}
type _ResponseInit = typeof globalThis extends { onmessage: any } ? {}
: import("undici-types").ResponseInit;
type _File = typeof globalThis extends { onmessage: any } ? {} : import("node:buffer").File;
type _WebSocket = typeof globalThis extends { onmessage: any } ? {} : import("undici-types").WebSocket;
// #endregion Fetch and friends

declare global {
Expand Down Expand Up @@ -409,4 +410,8 @@ declare global {
File: infer T;
} ? T
: typeof import("node:buffer").File;

interface WebSocket extends _WebSocket {}
var WebSocket: typeof globalThis extends { onmessage: any; WebSocket: infer T } ? T
: typeof import("undici-types").WebSocket;
}
8 changes: 8 additions & 0 deletions types/node/test/globals-dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,11 @@
},
);
}

{
const server = new WebSocket("htps://example.com");
server.addEventListener("message", (event) => {
console.log(event.data);
});
server.send("some data");
}
8 changes: 8 additions & 0 deletions types/node/test/globals-non-dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,11 @@
const abort = new AbortController();
AbortSignal.any([abort.signal]); // $ExpectType AbortSignal
}

{
const server = new WebSocket("htps://example.com");
server.addEventListener("message", (event) => {
console.log(event.data);
});
server.send("some data");
}