Skip to content

[node] Update and clean up node:test definitions (v22.0 and previous versions) #70156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 6 commits into from
Aug 2, 2024
Merged

[node] Update and clean up node:test definitions (v22.0 and previous versions) #70156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e9d8c8
Improve module mock definitions
Renegade334 Jul 26, 2024
4e9b4be
Add snapshot namespace to node:test
Renegade334 Jul 26, 2024
28255f5
node:test cleanup
Renegade334 Jul 28, 2024
8681754
Remove >v22.0 features
Renegade334 Jul 28, 2024
c45dfce
CI
Renegade334 Jul 28, 2024
a823df3
Merge branch 'master' into node-test
Renegade334 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 96 additions & 81 deletions types/node/test.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

53 changes: 35 additions & 18 deletions types/node/test/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ run({
signal: new AbortController().signal,
timeout: 100,
inspectPort: () => 8081,
testNamePatterns: ["executed"],
testNamePatterns: ["executed", /^core-/],
only: true,
setup: (root) => {},
setup: (reporter) => {
// $ExpectType TestsStream
reporter;
},
watch: true,
shard: {
index: 1,
Expand Down Expand Up @@ -814,17 +817,41 @@ class TestReporter extends Transform {
}
_transform(event: TestEvent, _encoding: BufferEncoding, callback: TransformCallback): void {
switch (event.type) {
case "test:complete": {
const { file, column, line, details, name, nesting, testNumber, skip, todo } = event.data;
callback(
null,
`${name}/${details.duration_ms}/${details.type}/${details.error}/
${nesting}/${testNumber}/${todo}/${skip}/${file}/${column}/${line}`,
);
break;
}
case "test:coverage": {
const { summary, nesting } = event.data;
callback(null, `${nesting}/${summary.workingDirectory}/${summary.totals.totalLineCount}`);
break;
}
case "test:dequeue": {
const { file, column, line, name, nesting } = event.data;
callback(null, `${name}/${nesting}/${file}/${column}/${line}`);
break;
}
case "test:diagnostic": {
const { file, column, line, message, nesting } = event.data;
callback(null, `${message}/${nesting}/${file}/${column}/${line}`);
break;
}
case "test:enqueue": {
const { file, column, line, name, nesting } = event.data;
callback(null, `${name}/${nesting}/${file}/${column}/${line}`);
break;
}
case "test:fail": {
const { file, column, line, details, name, nesting, testNumber, skip, todo } = event.data;
callback(
null,
`${name}/${details.duration_ms}/${details.type}/
${details.error}/${nesting}/${testNumber}/${todo}/${skip}/${file}/${column}/${line}`,
`${name}/${details.duration_ms}/${details.type}/${details.error.cause}/
${nesting}/${testNumber}/${todo}/${skip}/${file}/${column}/${line}`,
);
break;
}
Expand All @@ -848,23 +875,13 @@ class TestReporter extends Transform {
break;
}
case "test:stderr": {
const { file, column, line, message } = event.data;
callback(null, `${message}/${file}/${column}/${line}`);
const { file, message } = event.data;
callback(null, `${message}/${file}`);
break;
}
case "test:stdout": {
const { file, column, line, message } = event.data;
callback(null, `${message}/${file}/${column}/${line}`);
break;
}
case "test:enqueue": {
const { file, column, line, name, nesting } = event.data;
callback(null, `${name}/${nesting}/${file}/${column}/${line}`);
break;
}
case "test:dequeue": {
const { file, column, line, name, nesting } = event.data;
callback(null, `${name}/${nesting}/${file}/${column}/${line}`);
const { file, message } = event.data;
callback(null, `${message}/${file}`);
break;
}
case "test:watch:drained":
Expand Down
Loading