[eslint]: add LegacyConfig type#70109
Closed
fasttime wants to merge 1 commit intoDefinitelyTyped:masterfrom
fasttime:eslint-v8-legacy-config
Closed
[eslint]: add LegacyConfig type#70109fasttime wants to merge 1 commit intoDefinitelyTyped:masterfrom fasttime:eslint-v8-legacy-config
LegacyConfig type#70109fasttime wants to merge 1 commit intoDefinitelyTyped:masterfrom
fasttime:eslint-v8-legacy-config
Conversation
Contributor
|
@fasttime Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70109,
"author": "fasttime",
"headCommitOid": "857fadc2acc1445ba43a0925d5bdf1fe71b92407",
"mergeBaseOid": "2f8015c1df2007087e2f94587a053fe15533c73a",
"lastPushDate": "2024-07-21T09:26:58.000Z",
"lastActivityDate": "2024-07-22T12:54:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint",
"kind": "edit",
"files": [
{
"path": "types/eslint/eslint-tests.ts",
"kind": "test"
},
{
"path": "types/eslint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pmdartus",
"j-f1",
"saadq",
"JasonHK",
"bradzacher",
"JounQin",
"bmish"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "bradzacher",
"date": "2024-07-22T12:54:08.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2241544159,
"ciResult": "pass"
} |
Contributor
|
🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin @bmish — please review this PR in the next few days. Be sure to explicitly select |
8 tasks
bradzacher
approved these changes
Jul 22, 2024
typescript-bot
added
the
Owner Approved
Member
|
Moved to #69957. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.This PR adds
Linter.LegacyConfigas an alias forLinter.Config.Linter.LegacyConfigwill represent the type for an eslintrc config object in both@types/eslint@8and@types/eslint@9.The
Linter.Configtype represents the default config object type for the targeted version of ESLint, which ist eslintrc config for v8 and flat config for v9. In@types/eslint@9, the eslintrc config type will be only be accessible asLinter.LegacyConfig.