Skip to content

Nise add missing abort property #70107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 4 commits into from
Jul 24, 2024
Merged

Nise add missing abort property #70107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04fe489
Update index.d.ts
HarelM Jul 20, 2024
cf912c6
Update index.d.ts
HarelM Jul 20, 2024
c9f7c8a
Update nise-tests.ts
HarelM Jul 20, 2024
49e40e9
Update nise-tests.ts
HarelM Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions types/nise/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ export interface FakeXMLHttpRequest {
* When using respond, this property is populated with a parsed document if response headers indicate as much (see the spec)
*/
responseXML: Document;
/**
* `true` when the request has been aborted, `false` or undefined otherwise
*/
aborted: boolean;
/**
* The value of the given response header, if the request has been responded to (see respond).
* @param header
Expand Down
3 changes: 3 additions & 0 deletions types/nise/nise-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ function testFakeXMLHttpRequest() {
xhr.setStatus(404);
xhr.respond(200, { Accept: "application/json" }, "body");
xhr.error();

// $ExpectType boolean
xhr.aborted;
}

function testFakeXMLHttpRequestStatic() {
Expand Down