Skip to content

Don't use github search in publisher watchdog #70095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 3 commits into from
Jul 18, 2024
Merged

Don't use github search in publisher watchdog #70095

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
959430e
Don't use github search in publisher watchdog
jakebailey Jul 18, 2024
2bb0c67
Spacing
jakebailey Jul 18, 2024
267c176
fmt
jakebailey Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 40 additions & 15 deletions scripts/watchdog-publisher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ var gh = new Octokit({
auth: process.env.GITHUB_TOKEN,
});

// This script calls out to npm; ensure corepack doesn't complain if present.
process.env.COREPACK_ENABLE_STRICT = "0";

async function main() {
const prs = await recentPrs();
const longestLatency = recentPackages(prs);
Expand All @@ -21,29 +24,51 @@ async function main() {
*/
const packageNameFromIndexDts = /^types\/([^\/]+?)\/index.d.ts$/;

/**
* @param {"created" | "updated"} sort
*/
async function getTopFiveMerged(sort) {
const iterator = gh.paginate.iterator(gh.rest.pulls.list, {
owner: "DefinitelyTyped",
repo: "DefinitelyTyped",
state: "closed",
per_page: 100,
direction: "desc",
sort,
});

const result = [];

for await (const { data: pulls } of iterator) {
for (const pull of pulls) {
if (result.length === 5) {
return result;
}

if (!pull.merged_at) {
continue;
}

result.push(pull);
}
}

return result;
}

/** @returns {Promise<Map<string, { mergeDate: Date, pr: number, deleted: boolean }>>} */
async function recentPrs() {
console.log("search for 5 most recently created PRs");
const searchByCreatedDate = await gh.rest.search.issuesAndPullRequests({
q: "is:pr is:merged repo:DefinitelyTyped/DefinitelyTyped",
order: "desc",
per_page: 5,
page: 1,
});
const searchByCreatedDate = await getTopFiveMerged("created");
console.log("search for 5 most recently updated PRs");
const searchByUpdateDate = await gh.rest.search.issuesAndPullRequests({
q: "is:pr is:merged repo:DefinitelyTyped/DefinitelyTyped",
sort: "updated",
order: "desc",
per_page: 5,
page: 1,
});
const searchByUpdateDate = await getTopFiveMerged("updated");

/** @type {Map<string, { mergeDate: Date, pr: number, deleted: boolean }>} */
const prs = new Map();
for (const it of searchByCreatedDate.data.items) {
for (const it of searchByCreatedDate) {
await addPr(it, prs);
}
for (const it of searchByUpdateDate.data.items) {
for (const it of searchByUpdateDate) {
await addPr(it, prs);
}
return prs;
Expand Down