Skip to content

zipkin-context-cls: make namespace an optional argument, since it is #70062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jul 16, 2024
Merged

zipkin-context-cls: make namespace an optional argument, since it is #70062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/zipkin-context-cls/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ declare class CLSContext implements Context<any> {
getContext(): TraceId;
scoped<V>(callback: () => V): V;
letContext<V>(ctx: TraceId, callback: () => V): V;
constructor(name: string, supportAsyncAwait?: boolean);
constructor(name?: string, supportAsyncAwait?: boolean);
}

export = CLSContext;
7 changes: 3 additions & 4 deletions types/zipkin-context-cls/zipkin-context-cls-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { BatchRecorder, jsonEncoder, Tracer } from "zipkin";

import CLSContext = require("zipkin-context-cls");

const ctxImpl = new CLSContext("zipkin");
const ctxImplAsyncAwait = new CLSContext("zipkin", true);
const ctxImpl = new CLSContext();
const ctxImplName = new CLSContext("zipkin");
const ctxImplNameAsyncAwait = new CLSContext("zipkin", true);