Skip to content

[novnc__novnc]: Update RFB module path to match NoVnc v1.5 #70022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 2 commits into from
Jul 29, 2024
Merged

[novnc__novnc]: Update RFB module path to match NoVnc v1.5 #70022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b0b0d
fix(novnc__novnc): update RFB module path to match NoVnc v1.5
OlivierFL Jul 10, 2024
f935c59
[novnc__novnc]: Update RFB module path to match NoVnc v1.5
OlivierFL Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions types/novnc__novnc/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// eslint-disable-next-line @definitelytyped/no-declare-current-package
declare module "@novnc/novnc/core/rfb" {
declare module "@novnc/novnc/lib/rfb" {
/**
* An `object` specifying the credentials to provide to the server when authenticating.
*/
Expand Down Expand Up @@ -309,7 +309,7 @@ declare module "@novnc/novnc/core/rfb" {
}

// eslint-disable-next-line @definitelytyped/no-declare-current-package
declare module "@novnc/novnc/core/util/browser" {
declare module "@novnc/novnc/lib/util/browser" {
let isTouchDevice: boolean;
let dragThreshold: number;

Expand All @@ -324,7 +324,7 @@ declare module "@novnc/novnc/core/util/browser" {
}

// eslint-disable-next-line @definitelytyped/no-declare-current-package
declare module "@novnc/novnc/core/input/util" {
declare module "@novnc/novnc/lib/input/util" {
interface KeyboardEventBase {
char?: string;
charCode?: number;
Expand Down
12 changes: 6 additions & 6 deletions types/novnc__novnc/novnc__novnc-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as InputUtil from "@novnc/novnc/core/input/util";
import RFB from "@novnc/novnc/core/rfb";
import * as BrowserUtil from "@novnc/novnc/core/util/browser";
import * as InputUtil from "@novnc/novnc/lib/input/util";
import RFB from "@novnc/novnc/lib/rfb";
import * as BrowserUtil from "@novnc/novnc/lib/util/browser";

/* @novnc/novnc/core/rfb */
/* @novnc/novnc/lib/rfb */

// $ExpectType NoVncClient
const rfb = new RFB(window.document.body, "wss://example.local", {
Expand Down Expand Up @@ -36,7 +36,7 @@ rfb.clipboardPasteFrom("test"); // $ExpectType void
rfb.toDataURL(); // $ExpectType string
rfb.toBlob((blob) => blob); // $ExpectType void

/* @novnc/novnc/core/util/browser */
/* @novnc/novnc/lib/util/browser */

BrowserUtil.isTouchDevice; // $ExpectType boolean
BrowserUtil.dragThreshold; // $ExpectType number
Expand All @@ -48,7 +48,7 @@ BrowserUtil.isIOS(); // $ExpectType boolean
BrowserUtil.isSafari(); // $ExpectType boolean
BrowserUtil.isFirefox(); // $ExpectType boolean

/* @novnc/novnc/core/input/util */
/* @novnc/novnc/lib/input/util */

const keyboardEvent = {
char: "test",
Expand Down
2 changes: 1 addition & 1 deletion types/novnc__novnc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@types/novnc__novnc",
"version": "1.3.9999",
"version": "1.5.9999",
"projects": [
"https://github.com/novnc/noVNC"
],
Expand Down