Skip to content

[shimmer] Remove global Function modification #69966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Jul 8, 2024
Merged

[shimmer] Remove global Function modification #69966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad40df
[shimmer] Remove global `Function` modification
Jul 1, 2024
d93e570
Add test
Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions types/shimmer/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
declare global {
interface Function {
__wrapped?: boolean | undefined;
}
}

declare const shimmer: {
(options: { logger?(msg: string): void }): void;
wrap<Nodule extends object, FieldName extends keyof Nodule>(
Expand Down
2 changes: 1 addition & 1 deletion types/shimmer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@types/shimmer",
"version": "1.0.9999",
"version": "1.2.9999",
"projects": [
"https://github.com/othiym23/shimmer"
],
Expand Down
9 changes: 9 additions & 0 deletions types/shimmer/shimmer-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,12 @@ shimmer.massWrap([fish, turtle], ["age"], (originalAge) => {
shimmer.unwrap(fish, "name");

shimmer.massUnwrap([fish, turtle], ["age"]);

// The following may look weird and unrelated to the package but shimmer had a global type definition that broke the following code:
// https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69966
function randomFunction() {}
// eslint-disable-next-line @typescript-eslint/ban-types
function randomFunctionThatTakesFunction(f: Required<Function>) {
return f;
}
randomFunctionThatTakesFunction(randomFunction);