fix: drop incorrect types for webtorrent org packages: webtorrent, create-torrent, parse-torrent, bittorrent-protocol #69947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ThaUnknown Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 4 packages in this PR (and infra files)
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69947,
"author": "ThaUnknown",
"headCommitOid": "138483507c2f200b2d849c6a5fdfd767a79c6f2c",
"mergeBaseOid": "b4ae44884a5a4a56d6059d81f1567d3f6983dbe8",
"lastPushDate": "2024-06-29T10:47:03.000Z",
"lastActivityDate": "2024-07-05T19:49:13.000Z",
"mergeOfferDate": "2024-07-05T19:48:12.000Z",
"mergeRequestDate": "2024-07-05T19:49:13.000Z",
"mergeRequestUser": "ThaUnknown",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "bittorrent-protocol",
"kind": "delete",
"files": [
{
"path": "types/bittorrent-protocol/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/bittorrent-protocol/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/bittorrent-protocol/bittorrent-protocol-tests.ts",
"kind": "test"
},
{
"path": "types/bittorrent-protocol/index.d.ts",
"kind": "definition"
},
{
"path": "types/bittorrent-protocol/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/bittorrent-protocol/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"feross",
"tlaziuk",
"h1b9b"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "create-torrent",
"kind": "delete",
"files": [
{
"path": "types/create-torrent/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/create-torrent/create-torrent-tests.ts",
"kind": "test"
},
{
"path": "types/create-torrent/index.d.ts",
"kind": "definition"
},
{
"path": "types/create-torrent/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/create-torrent/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"jesec"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "parse-torrent",
"kind": "delete",
"files": [
{
"path": "types/parse-torrent/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/parse-torrent/index.d.ts",
"kind": "definition"
},
{
"path": "types/parse-torrent/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/parse-torrent/parse-torrent-tests.ts",
"kind": "test"
},
{
"path": "types/parse-torrent/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"niieani",
"tlaziuk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "webtorrent",
"kind": "delete",
"files": [
{
"path": "types/webtorrent/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/webtorrent/index.d.ts",
"kind": "definition"
},
{
"path": "types/webtorrent/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/webtorrent/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/webtorrent/webtorrent-tests.ts",
"kind": "test"
}
],
"owners": [
"niieani",
"tlaziuk",
"gjuchault",
"cheeseandcereal"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "iisaduan",
"date": "2024-07-05T19:47:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2198099998,
"ciResult": "pass"
} |
typescript-bot
added
Edits Infrastructure
Edits multiple packages
Check Config
Contributor
|
🔔 @feross @tlaziuk @h1b9b @jesec @niieani @gjuchault @cheeseandcereal — please review this PR in the next few days. Be sure to explicitly select |
iisaduan
approved these changes
Jul 5, 2024
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Author
|
Ready to merge |
|
@iisaduan @ThaUnknown Consider reading https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html and providing actual types definitions. If you still do not wish to provide them, this PR should be reverted. |
Collaborator
|
@proton-ab This is my mistake, for not examining the source packages closely enough. I had assumed "we use JsDoc" meant they were generating any needed definition with the |
iisaduan
added a commit
that referenced
this pull request
Jul 16, 2024
…g packag…" This reverts commit 2d678cd.
Collaborator
|
@ThaUnknown I am reverting this for now, so users can receive types that are not Alternatively, if you do not wish to ship definitions with webtorrent's packages, you could use the |
Contributor
Author
|
it does provide jsdoc types, @iisaduan then simply make it return window or something, it doesn't matter since the types are completely wrong anyways |
Contributor
Author
|
you do not understand that these types are forced in vs code and break our entire development process inside webtorrent |
16 tasks
Collaborator
|
@ThaUnknown What do you mean by "forced in vscode"? Is this only an issue for developers of webtorrent, or for users as well? TypeScript shouldn't be able to reference DT types unless they are installed and referenced, and if it is a VScode only problem, you should be able to disable the extensions or features that are causing the issues. |
Contributor
Author
|
@iisaduan I mean that, when u take a normal vscode install, import webtorrent: this is a massive issue for us as developers of webtorrent, because we get INACCURATE errors, in OUR OWN packages! it's insane to me that some1 can force inaccurate types on a module, and the maintainers of said module can't do anything about it it gets worse, every week we'll have a couple of people go into webtorrent's discord, or github issues, cry about something not working, just to figure out they were miss-lead by the incorrect types and tried using interfaces or methods which either don't exist, or return different data than what the types specify you can't just disable vscode's "javascript language features" extension, that breaks intellisense, autocomplete, syntax highlighting and everything else js related I considered simply adding a d.ts file to all webtorrent modules which simply export an |
Member
Where? https://www.npmjs.com/package/webtorrent contains no Just using JSDoc in your project is not sufficient; you need to actually run typescript or something to publish those types if you believe your types to be accurate. That or, the package on DT needs to be updated to match what you expect. The "forcing" here is just "automatic type acquisition", which can be controlled via: https://www.typescriptlang.org/tsconfig/#typeAcquisition If someone has not installed types, the editor will try and download types, and those must come from DT unless the webtorrent package itself provides them. |
Contributor
Author
but that is the exact use case of JSDoc? webtorrent is not compiled in any way, that's the way it's designed?
it's a javascript project, we want nothing to do with typescript, and we intentionally don't need to use any of it's tooling, yet we're being punished by this
you do it then? I don't think you're fully aware of what you're suggesting, we're talking about writing types for over 40 thousand lines of code, I don't have that kind of time, I'm almost solo maintaining and leading this project, with some help from @SilentBot1 in my spare time, that kind of task is way above what I can do
yes, and to disable this, you need to bring in typescript tooling and configuration into your project, wohoooo, these are raw JS projects as I said, I'm perfectly fine with simply adding a |
Member
Not exactly; JS code is only a last resort when loaded by tsserver, which powers all JS and TS editing in most editors.
You can set
You're totally free to do that; it's your package after all, but users will expect this to work. But there are better options.
#69947 (comment) gave the correct way for your case; you can use JSDoc, you just have to use TypeScript to generate some extra files to put in your package. This is how I went to the webtorrent package and did this: diff --git a/.gitignore b/.gitignore
index 2c7a4c8..32d403b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,3 +3,4 @@ package-lock.json
webtorrent.debug.js
sw.debug.js
pnpm-lock.yaml
+types/
diff --git a/package.json b/package.json
index 39f9d28..c747ea6 100644
--- a/package.json
+++ b/package.json
@@ -112,6 +112,7 @@
"tape": "^5.8.1",
"terser-webpack-plugin": "^5.3.10",
"timers-browserify": "^2.0.12",
+ "typescript": "^5.5.3",
"webpack": "^5.92.1",
"webpack-cli": "^5.1.4",
"webtorrent-fixtures": "1.7.5"
@@ -155,6 +156,7 @@
],
"license": "MIT",
"main": "index.js",
+ "types": "types/index.d.ts",
"repository": {
"type": "git",
"url": "git://github.com/webtorrent/webtorrent.git"
@@ -164,8 +166,9 @@
"build-chromeapp": "webpack --config ./scripts/chromeapp.webpack.js",
"build-js": "webpack --config ./scripts/browser.webpack.js",
"build-js-worker": "webpack --config ./scripts/worker.webpack.js",
- "prepublishOnly": "npm run build && npm run update-authors",
+ "prepublishOnly": "npm run build && npm run update-authors && npm run types",
"preversion": "npm run build && npm run update-authors",
+ "types": "tsc",
"size": "npm run size-js && npm run size-disc",
"size-disc": "npm run build-js && cat ./dist/webtorrent.min.js | discify --open",
"size-js": "npm run build-js && cat ./dist/webtorrent.min.js | gzip | wc -c",
diff --git a/tsconfig.json b/tsconfig.json
new file mode 100644
index 0000000..cdad268
--- /dev/null
+++ b/tsconfig.json
@@ -0,0 +1,21 @@
+{
+ // Change this to match your project
+ "include": ["index.js", "lib/**/*"],
+ "compilerOptions": {
+ // Tells TypeScript to read JS files, as
+ // normally they are ignored as source files
+ "allowJs": true,
+ // Generate d.ts files
+ "declaration": true,
+ // This compiler run should
+ // only output d.ts files
+ "emitDeclarationOnly": true,
+ // Types should go into this directory.
+ // Removing this would place the .d.ts files
+ // next to the .js files
+ "outDir": "types",
+ // go to js file when using IDE functions like
+ // "Go to Definition" in VSCode
+ "declarationMap": true
+ }
+ }
Which generated types (albeit, very incomplete, as your JSDoc is not complete):
|
Contributor
Author
yeah, but I don't see how having incorrect types is in any way better than simply using type inheritance you say "its your package after all" [i'm a part of the org, not the owner of the org] yet we can't control this behavior or types, even tho they are by default forced in the most popular js editor in the world? |
Member
|
I'm really not sure what you're trying to say. I don't know what "type inheritance" is. We can all "control" the types, but the way the editor works is set in stone. Types being out of date is a natural state of things when packages do not ship types themselves; DefinitelyTyped is a community project powered by third party contributors improving things. The ways forward are:
|
Contributor
Author
|
I'm saying "why are maintainers of packages hassled with extra work, that they never signed up for without being able to control it"
|
Member
|
Given the empty types package has already been published at 2.0.0, there's no undoing the fact that everyone using your package will now have no types at all (or at best, types attempted to be pulled from JS), except to either restore newer types here or to publish types within your package. So, we can just remove the types from here and nobody is any worse off than they already are (which is to say, still bad). It's a little bit odd that you are using JSDoc but are saying that they're not accurate; surely you want accurate types in your own codebase. Anything you do to make the JSDoc types more accurate in your codebase are going to make the types better for those who consume your package; you're really just writing TypeScript in comments. That's all VS Code is. For the second to last bullet point, I don't think the result is "the same". If you generate types from your codebase, users will get exactly the same experience you do when you work on your codebases today. All TypeScript is doing is exporting them to a separate file. |
Contributor
Author
|
webtorrent was started over 10 years ago, this was long before there were standards for these things, since then the codebase outgrew the people that built it, the JSDoc was placed where people had time to place it, this is completely 0 profit FOSS, it's a miracle there even are any JSDoc types, again you don't fully grasp how insanely complex of a library webtorrent is, and just how much time it would take to define the types for this, even these old types were quite inaccurate
it is different, not fully specified types generated from jsdoc are different from loose types, to fix this we would need to update jsdoc in a lot of places, at which point might as well just define the types. strict types with missing fields will throw errors when u try to access those missing fields, loose types wont error |
TheHamsterBot
added a commit
to XAuthSystems/DefinitelyTyped
that referenced
this pull request
Aug 4, 2024
* 🤖 Merge PR DefinitelyTyped#69843 Update 6.0 and 6.2 definitions by @Parjak39 * 🤖 Merge PR DefinitelyTyped#69673 [@types/node] Fix dns error code types by @jculvey * 🤖 Merge PR DefinitelyTyped#69660 [@types/express-serve-static-core] 🏷️ Add `Promise<void>` to `RequestHandler`'s return type by @NatoBoram * Revert "[@types/express-serve-static-core] 🏷️ Add `Promise<void>` to `RequestHandler`'s return type" (DefinitelyTyped#69845) * 🤖 Merge PR DefinitelyTyped#69832 [webpack-react-component-name] added type definitions by @DorianLatchague * 🤖 Merge PR DefinitelyTyped#69709 [@types/wordpress__block-editor] Allow first param of innerBlocksProps to be output of useBlockProps by @mikeybinns * Offset watchdog crons (DefinitelyTyped#69848) * 🤖 Merge PR DefinitelyTyped#69850 Update @types/bun to 1.1.14 by @calebamiles * 🤖 Merge PR DefinitelyTyped#69839 Add types for random-access-storage by @EvanHahn * 🤖 Merge PR DefinitelyTyped#69826 [@types/chromecast-caf-receiver] Extensible customData types by @steve-taylor * 🤖 Merge PR DefinitelyTyped#69836 add back my user as an owner by @maxiicodes * [office-js][office-js-preview] (OfficeTheme) Document isDarkTheme and themeId properties (DefinitelyTyped#69663) * 🤖 Merge PR DefinitelyTyped#69819 fix(node): child_process:for takes URL by @peterblazejewicz * 🤖 Merge PR DefinitelyTyped#69773 [@types/uuid]: Update for uuid v10 by @joshkel Co-authored-by: Andrew Haines <[email protected]> * 🤖 Merge PR DefinitelyTyped#69853 [@npmcli/arborist] Fix edgesOut and edgesIn types by @forivall * 🤖 Merge PR DefinitelyTyped#69786 add type for ezuikit-js package by @daiwanxing Co-authored-by: daiwanxing <[email protected]> * 🤖 Merge PR DefinitelyTyped#69849 [@npmcli/arborist] Fix Node.edgesOut and Define Node.isWorkspace by @russellhaering * 🤖 Merge PR DefinitelyTyped#69872 [@npmcli/arborist] Add Myself as Owner by @russellhaering * 🤖 Merge PR DefinitelyTyped#69860 Add types for random-access-file by @EvanHahn * 🤖 Merge PR DefinitelyTyped#69869 Add missing type definition for `http-link-header` package `toString()` method. by @ddembo * 🤖 Merge PR DefinitelyTyped#69856 feat(node): pass generic function implementation to `mockImplementation` and `mockImplementationOnce` for node:test by @bacebu4 * 🤖 Merge PR DefinitelyTyped#69857 feat(mocha): add missing failZero option by @johanneswuerbach * 🤖 Merge PR DefinitelyTyped#69876 [@types/tabulator-tables] fixed setData for invoking without any parameter as per official docs by @md-redwan-hossain * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69668 Add riskCorrelationId to @types/braintree-web DataCollector by @arks71 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69868 [@types/chromecast-caf-receiver] Add start and end to LiveSeekableRange by @KimmyWFox * 🤖 dprint fmt * 🤖 Update CODEOWNERS * Preemptively fix broken ExpectTypes (DefinitelyTyped#69881) * 🤖 Update support window * [office-js] [office-js-preview] (Word) Get from CDN, close API not on web (DefinitelyTyped#69897) * Bump the github-actions group with 2 updates (DefinitelyTyped#69891) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69900 Add missing type definition for package `http-link-header` method `setUnique()`. by @ddembo * 🤖 Merge PR DefinitelyTyped#69767 [gamedig] fix import when using `moduleResolution: node16` by @a-sync * 🤖 Merge PR DefinitelyTyped#69781 [k6] Fix `ResponseBody` type to use `ArrayBuffer` instead of `bytes` by @KOConchobhair * 🤖 Merge PR DefinitelyTyped#69901 [@types/react-instantsearch-dom] Add onFocus to SearchBoxProps by @huyenltnguyen * 🤖 Merge PR DefinitelyTyped#69903 [@types/jqueryui] Button method return types by @Daniel-Knights * [office-js][office-js-preview] (DevicePermission) Clarify values returned by requestPermissions and requestPermissionsAsync (DefinitelyTyped#69854) * [office-js-preview] (Outlook) Document errorMessageMarkdown property (DefinitelyTyped#68642) * 🤖 Merge PR DefinitelyTyped#69735 Node auth users settings update by @randyn * 🤖 Merge PR DefinitelyTyped#69879 [node] events: improve static methods, fix broken reversion by @Renegade334 * 🤖 Merge PR DefinitelyTyped#69887 fix 'frictionStuffness' -> 'frictionStiffness' type on p2 types by @pagoru * 🤖 Merge PR DefinitelyTyped#69892 [webxr] Add missing s for XRInputSourcesChangeEvent by @willeastcott * 🤖 Merge PR DefinitelyTyped#69902 [@types/k6] Type annotations for version v0.52.0 by @joanlopez Co-authored-by: Johan Suleiko Allansson <[email protected]> * 🤖 Merge PR DefinitelyTyped#69893 [@types/micromatch] Add new negatedExtglob state to result of scan by @sergeiivankov * 🤖 Merge PR DefinitelyTyped#69908 Fix some definitions for qz-tray by @sheck * 🤖 Merge PR DefinitelyTyped#69917 [styled-theming] use new conditional ts-expect-ignore by @jakebailey * 🤖 Merge PR DefinitelyTyped#69918 update Version of bun-types in @types/bun to 1.1.17 by @sk337 * 🤖 Merge PR DefinitelyTyped#69696 [@types/lodash] Patches `GetFieldType<>` for paths with multiple square… by @birdofpreyru * [office-js][office-js-preview] (Outlook) Document instances when inReplyTo returns null (DefinitelyTyped#69910) * 🤖 Merge PR DefinitelyTyped#69687 Add template import type for uniqueId helper by @vstefanovic97 Co-authored-by: vstefanovic97 <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69750 fix: typescript compilation error in lib/webdriver.d.ts by @ankianan Co-authored-by: Ankit Anand <[email protected]> Co-authored-by: Gabriela Araujo Britto <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69936 fix(clownface): improve support iterables in overloads by @tpluscode * 🤖 Merge PR DefinitelyTyped#69725 relay-runtime - Improve type-safety of RecordProxy#getOrCreateLinkedRecord by @JCMais * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69927 rails__actioncable update createConsumer type to accept function which returns string by @cooljacob204 * 🤖 Merge PR DefinitelyTyped#69935 [postcss-functions] fix plugin options type by @echocrow * 🤖 Merge PR DefinitelyTyped#69613 [WebXR] Add hapticActuators to gamepad on XRInputSource by @sorskoot * 🤖 Merge PR DefinitelyTyped#69729 (@types/exaroton) update exaroton types to 1.11 by @maxiicodes Signed-off-by: Maximilian Hofmann <[email protected]> * 🤖 Merge PR DefinitelyTyped#69939 [three] r166 by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#69890 [gapi.client.*] Bulk update Google API namespace by @Maxim-Mazurok * 🤖 Merge PR DefinitelyTyped#69859 chore: upgrade facebook nodejs business sdk to version 20 by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#69942 chore: sync updates to google.maps by @googlemaps-bot Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69948 [micromatch] Remove myself from owners by @glen-84 * 🤖 Merge PR DefinitelyTyped#69949 [oidc-provider] v8.5.0 bump by @panva * 🤖 Merge PR DefinitelyTyped#69905 [@types/picomatch] Add new negatedExtglob state to result of scan by @sergeiivankov Co-authored-by: Sergei Ivankov <[email protected]> * 🤖 Merge PR DefinitelyTyped#69771 culori: Add XYB colorspace, missing fns, and culori/css + culori/all entry points by @drwpow * Only check watchdog every two hours (DefinitelyTyped#69956) * 🤖 Merge PR DefinitelyTyped#69686 Update index.d.ts by @zulander1 * 🤖 Update CODEOWNERS * Change mergebot links in README (DefinitelyTyped#69968) * 🤖 Merge PR DefinitelyTyped#69866 Allow react resizable axis prop to have type none by @jamcgre * 🤖 Merge PR DefinitelyTyped#69833 [better-sqlite3] Add VirtualTableOptions rows params by @cooolbros * 🤖 Merge PR DefinitelyTyped#69921 [Poool-engage] - Add types for poool Engage by @maximedasilva * 🤖 Merge PR DefinitelyTyped#69969 [sharedb] Add emitter types to `MilestoneDB` by @alecgibson * 🤖 Merge PR DefinitelyTyped#69973 Clerk.io Fix wrong base response key by @tmmgrafikr * 🤖 Merge PR DefinitelyTyped#69873 [cloudflare-turnstile] updated render parameters types as per cloudfl… by @artem328 * 🤖 Merge PR DefinitelyTyped#69979 [oidc-provider] named Provider export, type exports by @panva * [office-js][office-js-preview] (Outlook) Correct inReply property note (DefinitelyTyped#69976) * [office-js][office-js-preview] (Outlook) Add note on supported mailbox types (DefinitelyTyped#69984) * VS Code 1.91 types update (DefinitelyTyped#69985) * 🤖 Merge PR DefinitelyTyped#69982 Update encoding-japanese for v2.2.0 by @syumai * 🤖 Merge PR DefinitelyTyped#69909 Fixed matchings_index and waypoint_index in types/project-osrm__osrm by @torinori * 🤖 Merge PR DefinitelyTyped#69989 Sync latest changes to @types/google-publisher-tag by @publisher-ads-audits-bot Co-authored-by: jimper <[email protected]> * 🤖 Merge PR DefinitelyTyped#69895 feat(node): Add mock module by @rozzilla Signed-off-by: Roberto Bianchi <[email protected]> * 🤖 Merge PR DefinitelyTyped#69947 fix: drop incorrect types for webtorrent org packages: webtorrent, create-torrent, parse-torrent, bittorrent-protocol by @ThaUnknown * Remove contributors with deleted accounts (DefinitelyTyped#69959) Co-authored-by: TypeScript Bot <[email protected]> * fix eslint readonly array * 🤖 Merge PR DefinitelyTyped#69922 thunderbird-webext-browser: update of definitions to API version Thunderbird 127.0 by @JimDanner * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69960 [ramda] bump types-ramda to 0.30.1 by @Harris-Miller * 🤖 Merge PR DefinitelyTyped#69965 add types for [flubber] by @huxulm Co-authored-by: Isabel Duan <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69981 [cli-progress] Add isActive field to bars by @NoahAndrews * 🤖 Merge PR DefinitelyTyped#69995 [telegram-web-app] Update Telegram Web App to API 7.7 by @deptyped * 🤖 Merge PR DefinitelyTyped#69996 style: rewrap doc strings for telegram-web-app by @KnorpelSenf * 🤖 Merge PR DefinitelyTyped#69945 [carbon-components-react] Remove myself from the contributors by @sgregoire * 🤖 Merge PR DefinitelyTyped#69955 [haxball-headless-browser] Fixes setPlayerAvatar by @RicardoPinto26 * 🤖 Merge PR DefinitelyTyped#69913 [@types/jmuxer] Add missing properties to `JMuxer.Options` by @vrumger * 🤖 Merge PR DefinitelyTyped#69951 fix: [facebook-nodejs-business-sdk] constructor type params to optional by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#69966 [shimmer] Remove global `Function` modification by @lforst * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#69999 [invity-api]: Add default amounts for fiat currencies by @LukasRada * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69998 bugfix: [facebook-nodejs-business-sdk] add delete function types to classes by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#70003 [Poool-engage] - rename namespace and add display condition by @maximedasilva * 🤖 Merge PR DefinitelyTyped#69975 fix(karma-webpack): make webpackMiddleware optional by @Den-dp * 🤖 Merge PR DefinitelyTyped#69904 [@types/picomatch] Add new `windows` options field by @sergeiivankov Co-authored-by: Sergei Ivankov <[email protected]> * 🤖 Merge PR DefinitelyTyped#69852 A JsonLdArray is an array of JsonLdObj's not an array with a single JsonLdObj by @agustaf9 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70013 fix(sparqljs): inaccurate types of INSERT/DELETE operations by @tpluscode * 🤖 Merge PR DefinitelyTyped#69974 [readable-stream] fix signature of pipe in Duplex class by @JKRhb * 🤖 Merge PR DefinitelyTyped#69944 [@types/set-cookie-parser] Revert updated `sameSite` typings by @nwalters512 * 🤖 Merge PR DefinitelyTyped#69988 feat(aws-lambda): Add generics for stronger typing of CFN/CDK Custom Resource properties by @LucianoTaranto * 🤖 Merge PR DefinitelyTyped#69938 Improved definitions for awesome-notifications by @seebeen Co-authored-by: Isabel Duan <[email protected]> * 🤖 Merge PR DefinitelyTyped#70014 [plotly.js] Updated types for LayoutAxis and Axis to match current API by @acolvin-h1 * 🤖 Merge PR DefinitelyTyped#70021 [openui5] Update the definition files for OpenUI5 1.126 by @akudev * 🤖 Merge PR DefinitelyTyped#70015 [easy-soap-request] update axios dependency to v1.6.7 by @chimurai * 🤖 Merge PR DefinitelyTyped#70016 [imapflow] Update types for v1.0.164 (`fetchAll` method) by @Remscar * feat(relay-test-utils): update types to match latest version and add option for stricter typing for resolvers (DefinitelyTyped#70020) * [mixpanel-browser] Support api_payload_format for Config object (DefinitelyTyped#69971) * [office-js] [office-js-preview] Update references to right-click (DefinitelyTyped#70023) * 🤖 Merge PR DefinitelyTyped#70009 [`mapbox__mapbox-sdk`] - Add types for missing `@mapbox/mapbox-sdk` and `isochrone` service by @tetarchus * 🤖 Merge PR DefinitelyTyped#70034 [delaunator] Use type parameter correctly on class Delaunator by @dgreensp * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70033 matter.js -> (small typo) Update index.d.ts by @JoaoGeraldes * 🤖 Merge PR DefinitelyTyped#70025 Update index.d.ts for `keythereum`: Add types of `recover` function by @sircoon4 * 🤖 Merge PR DefinitelyTyped#70024 feat(ws): Enable `addEventListener`/`removeEventListener` to Work with Unions of Event Types by @ITenthusiasm * 🤖 Merge PR DefinitelyTyped#70026 [@types/modesl] - Event getHeader() method returns string | null by @paolopiaggio * 🤖 Merge PR DefinitelyTyped#69978 chore: update woosmap.map by @wgsadmin Co-authored-by: JeanCarriere <[email protected]> * 🤖 Update CODEOWNERS * Update scripts target to es2023 (DefinitelyTyped#70055) * 🤖 Merge PR DefinitelyTyped#69970 [react] Add failing tests for returning `ReactNode` from an async Component by @eps1lon * Bump the github-actions group across 1 directory with 3 updates (DefinitelyTyped#70047) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69885 [@types/espree] Update to 10.1.0 by @e6nlaq * 🤖 Merge PR DefinitelyTyped#69787 [carbon-components-react] Ensure forwards compatiblity with React 19 by @eps1lon * 🤖 Merge PR DefinitelyTyped#69788 [react-bootstrap] Ensure forwards compatiblity with React 19 by @eps1lon * 🤖 Merge PR DefinitelyTyped#69894 Cytoscape closeness centrality normalized result by @cneumann * 🤖 dprint fmt * [carbon-components-react] Removing myself from owners. (DefinitelyTyped#70057) * 🤖 Merge PR DefinitelyTyped#69780 [dockerode] add version option for `buildImage` by @mikeseese * 🤖 Merge PR DefinitelyTyped#70042 [@types/critters-webpack-plugin] Update critters-webpack-plugin to 3.0.2 by @Gehbt * 🤖 Merge PR DefinitelyTyped#70039 [lodash] fix _.get return type cannot refer to correct type and default type in nested object with optional fields by @ncnthien * Revert "fix: drop incorrect types for webtorrent org packages: webtorrent, create-torrent, parse-torrent, bittorrent-protocol" (DefinitelyTyped#70059) * 🤖 Merge PR DefinitelyTyped#70012 react-datepicker v7 was migrated to TypeScript, typings no longer needed by @Cerber-Ursi Co-authored-by: Konstantin Bagrov <[email protected]> * 🤖 Merge PR DefinitelyTyped#70062 zipkin-context-cls: make namespace an optional argument, since it is by @mitchell-merry * 🤖 Merge PR DefinitelyTyped#70035 remove: @fcostarodrigo/walk by @tpluscode * 🤖 Merge PR DefinitelyTyped#70063 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <[email protected]> * 🤖 Merge PR DefinitelyTyped#70068 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <[email protected]> * Fix notNeededPackages for fcostarodrigo__walk (DefinitelyTyped#70069) * [mongoose-delete] Raise minimum TS version to 4.9 (DefinitelyTyped#70070) * [tabulator-tables] Update for new export maps upstream (DefinitelyTyped#70071) * 🤖 Merge PR DefinitelyTyped#69941 motion-sensors-polyfill: Correct GyroscopeSensorOptions Inheritance by @GenieTim * 🤖 Merge PR DefinitelyTyped#69820 node crypto sign should accept a private key in jwk format by @omkelderman * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69934 [ads-client] Allow `null` as `Settings` properties by @crishoj * 🤖 Merge PR DefinitelyTyped#69920 [react-simple-maps] Add missing hook types by @piercemorris * 🤖 Merge PR DefinitelyTyped#70075 Updates types for Recurly.js v4.29.1 by @recurly-integrations Co-authored-by: recurly-integrations <[email protected]> * 🤖 Merge PR DefinitelyTyped#70067 Update ari client. Add missing field protocol_id to Channel by @MGMDelphi * 🤖 Merge PR DefinitelyTyped#70065 [Poool-access][Poool-engage]: add ispoool boolean on every elements, event names and fix some stuff by @maximedasilva * 🤖 Merge PR DefinitelyTyped#70078 Fix Clerk.io Search response by @tmmgrafikr * Update contributors with renamed accounts (DefinitelyTyped#70045) Co-authored-by: TypeScript Bot <[email protected]> Co-authored-by: Jake Bailey <[email protected]> * [office-js][office-js-preview] (Outlook) Deprecate entity-based contextual APIs (DefinitelyTyped#69987) * 🤖 Merge PR DefinitelyTyped#70080 [@types/node-cmd] Adding type definitions by @e6nlaq * 🤖 Merge PR DefinitelyTyped#69950 [color-rgba] Fix return type by @MoonE * 🤖 Merge PR DefinitelyTyped#70081 [@types/jquery.validation] Adding customElements to ValidationOptions by @dhobi Co-authored-by: Daniel Hobi <[email protected]> * 🤖 dprint fmt * [office-js] [office-js-preview] (keyboard shortcuts) Ensure that APIs… (DefinitelyTyped#70085) * Update dprint cli (DefinitelyTyped#70092) * 🤖 Merge PR DefinitelyTyped#65463 Add printerSupport to mjml-core by @jimmyfortinx * Make ImportMeta.resolve conditional (DefinitelyTyped#70054) * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70093 [office-js][office-js-preview] (Outlook) Update recipient limit by @samantharamon * Don't use github search in publisher watchdog (DefinitelyTyped#70095) * 🤖 Merge PR DefinitelyTyped#70087 [d3-3d] add types for d3-3d by @aminya * 🤖 Merge PR DefinitelyTyped#69862 [plotly.js] Make width/height nullable in Plotly.toImage / Plotly.downloadImage by @billylittlefield * 🤖 Merge PR DefinitelyTyped#70053 qrcode-svg: add svg-viewbox option by @mb21 * Update dprint to pick up comment bugfix (DefinitelyTyped#70103) * [chrome-apps] Fix test for TS 5.6 (DefinitelyTyped#70104) * [dom-view-transitions] Fix for TS 5.6 (DefinitelyTyped#70106) * 🤖 Merge PR DefinitelyTyped#70102 [@types/oojs-ui] Refine annotation of OO.ui.Element.ScrollIntoViewConfig by @jwbth * 🤖 Merge PR DefinitelyTyped#70097 Update types for fabric: Add enablePointerEvents as a boolean feature to fabric canvas initialization. by @amoghasgekar * 🤖 Merge PR DefinitelyTyped#70100 [@types/streamtest] Embed types since 3.0.0 by @nfroidure * 🤖 Merge PR DefinitelyTyped#70108 [@types/ttf2woff2] Embed types since 6.0.0 by @nfroidure * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#70116 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <[email protected]> * 🤖 Merge PR DefinitelyTyped#69957 [eslint]: update to ESLint v9 by @fasttime Co-authored-by: Josh Goldberg ✨ <[email protected]> * 🤖 Merge PR DefinitelyTyped#69946 Lazy.js: fix many incorrect types and improve others by @djcsdy * Export inline fragment and condition (DefinitelyTyped#70124) * Fix always-truthy errors (DefinitelyTyped#70126) * 🤖 Merge PR DefinitelyTyped#70121 [cannon] fix typo `isFronmtWheel` to `isFrontWheel` by @bkmashiro * 🤖 dprint fmt * Support forthcoming changes to `Iterator` type in TS 5.6 (DefinitelyTyped#69632) Co-authored-by: Jake Bailey <[email protected]> * 🤖 Merge PR DefinitelyTyped#70111 Add new turndown options field preformattedCode by @hildoer * 🤖 Merge PR DefinitelyTyped#69994 [@types/chrome] Fix Window type in ExtensionSidebarPaneShownEvent by @hamax * 🤖 Merge PR DefinitelyTyped#69993 Adds webhook payload definitions by @jondewoo Co-authored-by: Jonathan Derrough <[email protected]> * 🤖 Merge PR DefinitelyTyped#69992 Adds Task custom fields definitions by @jondewoo Co-authored-by: Jonathan Derrough <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69899 Add missing type definitions for package `probe-image-size` deep imports. by @ddembo * 🤖 Merge PR DefinitelyTyped#70107 Nise add missing `abort` property by @HarelM * 🤖 Merge PR DefinitelyTyped#70123 [@types/aws-lambda] TransferFamilyAuthorizerEvent Password undefined by @TheRealBenJones * 🤖 Merge PR DefinitelyTyped#70118 chore: sync updates to google.maps by @googlemaps-bot Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> * Remove `stuartthomson` from dockerode owners (DefinitelyTyped#70066) * 🤖 Merge PR DefinitelyTyped#70117 Remove 'jump' property from markdown-it type definitions by @surenpoghosian * 🤖 Merge PR DefinitelyTyped#70130 [@types/govuk-frontend] Add new definition for govuk-frontend by @colinrotherham * 🤖 Merge PR DefinitelyTyped#70140 [three] r167 by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#70142 [three] r167 patches by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#70050 [@types/superagent] add form data append options on field function by @j-elmer123 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70145 [@types/camelize] fixes types for camelize package by @lukaskral * 🤖 Merge PR DefinitelyTyped#70148 [@mapbox-sdk]: Restrict `SimpleMarker` coordinates type by @jonahallibone * 🤖 Merge PR DefinitelyTyped#70125 [node] Add v22 typings by @Semigradsky Co-authored-by: Renegade334 <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70082 Update `relay-runtime` environment types to reflect the renaming of `requiredFieldLogger` to `relayFieldLogger` by @levibuzolic * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#70132 fix: WS server address can be null by @achingbrain * 🤖 Merge PR DefinitelyTyped#69871 [plotly.js] Update types for x and y axis names to match documentation by @mrtnbrst Co-authored-by: Jake Bailey <[email protected]> * 🤖 Merge PR DefinitelyTyped#69983 feat(heic-convert): add type definitions for 2.1.0 version by @leonardlib * [novnc__novnc]: Update RFB module path to match NoVnc v1.5 (DefinitelyTyped#70022) * Add event listeners typings for `fluent-ffmpeg` (DefinitelyTyped#70019) * [`mapbox-gl`] - Add missing `MapOptions` types (DefinitelyTyped#70008) * Remove contributors with deleted accounts (DefinitelyTyped#70158) Co-authored-by: TypeScript Bot <[email protected]> * [plotly.js] - Remove mtadams007 from code ownership. (DefinitelyTyped#70162) * 🤖 Merge PR DefinitelyTyped#70128 Updated to v1.31.0 by @tom-schier Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sumaya Hasan <[email protected]> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70144 [mapbox__mapbox-gl-draw] compatibility with MapBox GL js 3.5+ native types by @brookjordan * 🤖 Merge PR DefinitelyTyped#70079 [sharedb] Add `defaultType` and `transformPresence()` by @alecgibson * [office-js][office-js-preview] (Outlook) Remove outdated information from Office.EmailUser (DefinitelyTyped#70135) * 🤖 Merge PR DefinitelyTyped#70149 Update project website URL for voca by @pine * 🤖 Merge PR DefinitelyTyped#70155 [node] Remove post-22.0 features from v22.0.x package by @Renegade334 * 🤖 Merge PR DefinitelyTyped#70166 [node] Add global WebSocket by @Semigradsky * 🤖 Merge PR DefinitelyTyped#70182 [telegram-web-app] add support for Bot API 7.8 by @KnorpelSenf * 🤖 Merge PR DefinitelyTyped#70114 [chai] Fix assorted JSDoc typos by @JoshuaKGoldberg * 🤖 Merge PR DefinitelyTyped#70172 Update clerk.io author by @madsenmm * 🤖 Merge PR DefinitelyTyped#70187 Sync latest changes to @types/google-publisher-tag by @publisher-ads-audits-bot Co-authored-by: jimper <[email protected]> * Added quantum-circuit package types (DefinitelyTyped#70171) * Add json-to-go package types (DefinitelyTyped#70186) * Fix `sass-loader` Callback arguments (missing `content`) (DefinitelyTyped#70037) * VS Code 1.92 types update (DefinitelyTyped#70191) * [office-js][office-js-preview] (Outlook) Remove preview string from new Outlook on Windows references (DefinitelyTyped#70168) * 🤖 Merge PR DefinitelyTyped#70161 [@sap/approuter] fixes start config options to match definition by @nbblum * 🤖 Merge PR DefinitelyTyped#70156 [node] Update and clean up `node:test` definitions (v22.0 and previous versions) by @Renegade334 * 🤖 Merge PR DefinitelyTyped#70154 [node] Update typings to v22.1.0 by @Semigradsky * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70101 react-adal: Updated package.json: Added myself to the list of owners by @dkorolov1 * 🤖 dprint fmt --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Maximilian Hofmann <[email protected]> Signed-off-by: Roberto Bianchi <[email protected]> Co-authored-by: Jakep39 <[email protected]> Co-authored-by: James Culveyhouse <[email protected]> Co-authored-by: Nato Boram <[email protected]> Co-authored-by: Gabriela Araujo Britto <[email protected]> Co-authored-by: Dorian Latchague <[email protected]> Co-authored-by: Mikey Binns <[email protected]> Co-authored-by: Jake Bailey <[email protected]> Co-authored-by: caleb miles <[email protected]> Co-authored-by: Evan Hahn <[email protected]> Co-authored-by: Steve Taylor <[email protected]> Co-authored-by: Maximilian Hofmann <[email protected]> Co-authored-by: Sam Ramon <[email protected]> Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <[email protected]> Co-authored-by: Josh Kelley <[email protected]> Co-authored-by: Andrew Haines <[email protected]> Co-authored-by: Emily Marigold Klassen <[email protected]> Co-authored-by: Klein <[email protected]> Co-authored-by: daiwanxing <[email protected]> Co-authored-by: Russell Haering <[email protected]> Co-authored-by: David Dembo <[email protected]> Co-authored-by: bacebu4 <[email protected]> Co-authored-by: Johannes Würbach <[email protected]> Co-authored-by: Md. Redwan Hossain <[email protected]> Co-authored-by: TypeScript Bot <[email protected]> Co-authored-by: arks71 <[email protected]> Co-authored-by: KimmyWFox <[email protected]> Co-authored-by: Elizabeth Samuel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Dembo <[email protected]> Co-authored-by: a-sync <[email protected]> Co-authored-by: Kyle O'Connor <[email protected]> Co-authored-by: Huyen Nguyen <[email protected]> Co-authored-by: Daniel Knights <[email protected]> Co-authored-by: Randy Nguyen <[email protected]> Co-authored-by: René <[email protected]> Co-authored-by: Pablo González Rubio <[email protected]> Co-authored-by: Will Eastcott <[email protected]> Co-authored-by: Joan López de la Franca Beltran <[email protected]> Co-authored-by: Johan Suleiko Allansson <[email protected]> Co-authored-by: Sergei Ivankov <[email protected]> Co-authored-by: Nick Sheck <[email protected]> Co-authored-by: sk337 <[email protected]> Co-authored-by: Dr. Sergey Pogodin <[email protected]> Co-authored-by: Vuk <[email protected]> Co-authored-by: vstefanovic97 <[email protected]> Co-authored-by: Ankit Anand <[email protected]> Co-authored-by: Ankit Anand <[email protected]> Co-authored-by: Gabriela Araujo Britto <[email protected]> Co-authored-by: Tomasz Pluskiewicz <[email protected]> Co-authored-by: Jonathan Cardoso <[email protected]> Co-authored-by: Jacob Feldman <[email protected]> Co-authored-by: Crow <[email protected]> Co-authored-by: Sorskoot <[email protected]> Co-authored-by: Nathan Bierema <[email protected]> Co-authored-by: Maxim Mazurok <[email protected]> Co-authored-by: Rodin Hatokay <[email protected]> Co-authored-by: googlemaps-bot <[email protected]> Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> Co-authored-by: Glen <[email protected]> Co-authored-by: Filip Skokan <[email protected]> Co-authored-by: Sergei Ivankov <[email protected]> Co-authored-by: Drew Powers <[email protected]> Co-authored-by: Rohan Edman <[email protected]> Co-authored-by: Nathan Shively-Sanders <[email protected]> Co-authored-by: jamcgre <[email protected]> Co-authored-by: Revan <[email protected]> Co-authored-by: Maxime Da Silva <[email protected]> Co-authored-by: Alec Gibson <[email protected]> Co-authored-by: Tobias Mønster Madsen <[email protected]> Co-authored-by: Artem Vozhzhov <[email protected]> Co-authored-by: Michael Lively <[email protected]> Co-authored-by: syumai <[email protected]> Co-authored-by: torinori <[email protected]> Co-authored-by: Google Publisher Tags Bot <[email protected]> Co-authored-by: jimper <[email protected]> Co-authored-by: Roberto Bianchi <[email protected]> Co-authored-by: Cas_ <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Isabel Duan <[email protected]> Co-authored-by: JimDanner <[email protected]> Co-authored-by: Harris Miller <[email protected]> Co-authored-by: Huxulm <[email protected]> Co-authored-by: Noah Andrews <[email protected]> Co-authored-by: deptyped <[email protected]> Co-authored-by: KnorpelSenf <[email protected]> Co-authored-by: Sébastien <[email protected]> Co-authored-by: Ricardo Pinto <[email protected]> Co-authored-by: Avrumy <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Luky <[email protected]> Co-authored-by: Denis Bendrikov <[email protected]> Co-authored-by: Adam Gustafson <[email protected]> Co-authored-by: Jan Romann <[email protected]> Co-authored-by: Nathan Sarang-Walters <[email protected]> Co-authored-by: Luciano <[email protected]> Co-authored-by: Sibin Grašić <[email protected]> Co-authored-by: acolvin-h1 <[email protected]> Co-authored-by: Andreas Kunz <[email protected]> Co-authored-by: Steven Chim <[email protected]> Co-authored-by: Zachary <[email protected]> Co-authored-by: Stanisław <[email protected]> Co-authored-by: ko1ebayev <[email protected]> Co-authored-by: tetarchus <[email protected]> Co-authored-by: David Greenspan <[email protected]> Co-authored-by: João Geraldes <[email protected]> Co-authored-by: SEOKHUN KANG <[email protected]> Co-authored-by: Isaiah Thomason <[email protected]> Co-authored-by: paolopiaggio <[email protected]> Co-authored-by: wgsadmin <[email protected]> Co-authored-by: JeanCarriere <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: sakamotor <[email protected]> Co-authored-by: Carsten Neumann <[email protected]> Co-authored-by: Kyle Albert <[email protected]> Co-authored-by: Mike Seese <[email protected]> Co-authored-by: rgehbt <[email protected]> Co-authored-by: Nguyen Cong Nhat Thien <[email protected]> Co-authored-by: Cerber-Ursi <[email protected]> Co-authored-by: Konstantin Bagrov <[email protected]> Co-authored-by: Mitchell Merry <[email protected]> Co-authored-by: manz <[email protected]> Co-authored-by: Tim Bernhard <[email protected]> Co-authored-by: Olle Kelderman <[email protected]> Co-authored-by: Christian Rishøj <[email protected]> Co-authored-by: Pierce James Morris <[email protected]> Co-authored-by: recurly-integrations <[email protected]> Co-authored-by: recurly-integrations <[email protected]> Co-authored-by: MGMDelphi <[email protected]> Co-authored-by: MoonE <[email protected]> Co-authored-by: Daniel Hobi <[email protected]> Co-authored-by: Daniel Hobi <[email protected]> Co-authored-by: Jimmy Fortin <[email protected]> Co-authored-by: Amin Yahyaabadi <[email protected]> Co-authored-by: Billy Littlefield <[email protected]> Co-authored-by: Mauro Bieg <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: amoghasgekar <[email protected]> Co-authored-by: Nicolas Froidure <[email protected]> Co-authored-by: Francesco Trotta <[email protected]> Co-authored-by: Josh Goldberg ✨ <[email protected]> Co-authored-by: Daniel Cassidy <[email protected]> Co-authored-by: Robert Balicki <[email protected]> Co-authored-by: bakamashiro <[email protected]> Co-authored-by: Ron Buckton <[email protected]> Co-authored-by: Anthony Hildoer <[email protected]> Co-authored-by: Žiga Ham <[email protected]> Co-authored-by: Jonathan Derrough <[email protected]> Co-authored-by: Jonathan Derrough <[email protected]> Co-authored-by: Harel M <[email protected]> Co-authored-by: Ben Jones <[email protected]> Co-authored-by: Stuart <[email protected]> Co-authored-by: surenpoghosian <[email protected]> Co-authored-by: Colin Rotherham <[email protected]> Co-authored-by: John Elmer Semaya <[email protected]> Co-authored-by: Lukas Kral <[email protected]> Co-authored-by: Jonah Allibone <[email protected]> Co-authored-by: Dmitry Semigradsky <[email protected]> Co-authored-by: Renegade334 <[email protected]> Co-authored-by: Levi Buzolic <[email protected]> Co-authored-by: Alex Potsides <[email protected]> Co-authored-by: Martin <[email protected]> Co-authored-by: Leonardo Lira Becerra <[email protected]> Co-authored-by: OlivierFL <[email protected]> Co-authored-by: ChinHongTan <[email protected]> Co-authored-by: Michael Adams <[email protected]> Co-authored-by: Tomas Schier <[email protected]> Co-authored-by: Sumaya Hasan <[email protected]> Co-authored-by: Brook Jordan <[email protected]> Co-authored-by: Pine Mizune <[email protected]> Co-authored-by: René <[email protected]> Co-authored-by: Tobias Mønster Madsen <[email protected]> Co-authored-by: Dmytro Sapozhnyk <[email protected]> Co-authored-by: LemonNeko <[email protected]> Co-authored-by: Cédric Patchane <[email protected]> Co-authored-by: Nico Blum <[email protected]> Co-authored-by: Dmytro Korolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.These types for webtorrent's packages have been outdated for ages, and for the most part aren't needed because we use JSDoc where it's important.
These types are causing an insane amt of issues for us, both for development, and for maintaining, since VSCode incorrectly inherits DT's types, and people keep making issues complaining that a function works incorrectly, because these types are wrong and are telling them incorrect things.