Skip to content

motion-sensors-polyfill: Correct GyroscopeSensorOptions Inheritance #69941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 4 commits into from
Jul 16, 2024
Merged

motion-sensors-polyfill: Correct GyroscopeSensorOptions Inheritance #69941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ef4ee5
Correct GyroscopeSensorOptions Inheritance
GenieTim Jun 28, 2024
591c13d
Adjust code as requested by bot
GenieTim Jun 28, 2024
57b7069
Merge branch 'master' into patch-1
GenieTim Jun 28, 2024
1756dcf
Format code as requested by bot
GenieTim Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/motion-sensors-polyfill/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class GravitySensor extends Accelerometer {
constructor(options?: AccelerometerSensorOptions);
}

interface GyroscopeSensorOptions {
interface GyroscopeSensorOptions extends SensorOptions {
referenceFrame?: GyroscopeLocalCoordinateSystem | undefined; // defauts to "device"
}

Expand Down
30 changes: 24 additions & 6 deletions types/motion-sensors-polyfill/motion-sensors-polyfill-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,52 @@ import {
// GeolocationSensor,
} from "motion-sensors-polyfill";

const accelerometer = new Accelerometer();
const accelerometer = new Accelerometer({
frequency: 60,
referenceFrame: "device",
});
accelerometer.timestamp;
accelerometer.x;
accelerometer.y;
accelerometer.z;

const linearAccelerationSensor = new LinearAccelerationSensor();
const linearAccelerationSensor = new LinearAccelerationSensor({
frequency: 60,
referenceFrame: "device",
});
linearAccelerationSensor.timestamp;
linearAccelerationSensor.x;
linearAccelerationSensor.y;
linearAccelerationSensor.z;

const gravitySensor = new GravitySensor();
const gravitySensor = new GravitySensor({
frequency: 60,
referenceFrame: "screen",
});
gravitySensor.timestamp;
gravitySensor.x;
gravitySensor.y;
gravitySensor.z;

const gyroscope = new Gyroscope();
const gyroscope = new Gyroscope({
frequency: 60,
referenceFrame: "device",
});
gyroscope.x;
gyroscope.y;
gyroscope.z;

const absoluteOrientation = new AbsoluteOrientationSensor();
const absoluteOrientation = new AbsoluteOrientationSensor({
frequency: 60,
referenceFrame: "device",
});
absoluteOrientation.timestamp;
absoluteOrientation.quaternion;

const relativeOrientation = new RelativeOrientationSensor();
const relativeOrientation = new RelativeOrientationSensor({
frequency: 60,
referenceFrame: "screen",
});
relativeOrientation.timestamp;
relativeOrientation.quaternion;

Expand Down
2 changes: 1 addition & 1 deletion types/motion-sensors-polyfill/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "@types/motion-sensors-polyfill",
"version": "0.3.9999",
"projects": [
"https://github.com/kenchris/lit-element"
"https://github.com/kenchris/sensor-polyfills"
],
"devDependencies": {
"@types/motion-sensors-polyfill": "workspace:."
Expand Down