Skip to content

[styled-theming] use new conditional ts-expect-ignore #69917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jun 26, 2024
Merged

[styled-theming] use new conditional ts-expect-ignore #69917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/styled-theming/styled-theming-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const Button = styled.button`

const elementWithoutProp = React.createElement(Button);
const elementWithCorrectProp = React.createElement(Button, { kind: "secondary" });
// TODO(react): Unclear why this doesn't error. Probably picking an overload where excess props are fine.
// @ts-expect-error >=5.6
const element = React.createElement(Button, { kind: "wrong variant" });
// @ts-expect-error
<Button kind="wrong variant" />;