Skip to content

[@npmcli/arborist] Fix Node.edgesOut and Define Node.isWorkspace #69849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jun 21, 2024
Merged

[@npmcli/arborist] Fix Node.edgesOut and Define Node.isWorkspace #69849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion types/npmcli__arborist/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ declare namespace Arborist {
* Edges in the dependency graph indicating nodes that this node depends
* on, which resolve its dependencies.
*/
edgesOut: Edge[];
edgesOut: Map<string, Edge>;
/** Edges in the dependency graph indicating nodes that depend on this node. */
edgesIn: Edge[];

Expand All @@ -216,6 +216,8 @@ declare namespace Arborist {

get inBundle(): boolean;

get isWorkspace(): boolean;

/** Errors encountered while parsing package.json or version specifiers. */
errors: Error[];

Expand Down
2 changes: 2 additions & 0 deletions types/npmcli__arborist/npmcli__arborist-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ const arb = new Arborist({

arb.loadActual().then(tree => {
tree; // $ExpectType Node
tree.isWorkspace; // $ExpectType boolean
tree.edgesOut; // $ExpectType Map<string, Edge>
});

arb.loadVirtual().then(tree => {
Expand Down