[@types/express-serve-static-core] 🏷️ Add Promise<void> to RequestHandler's return type
#69846
Conversation
|
@NatoBoram Thank you for submitting this PR! This is a live comment that I will keep updated. 16 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69846,
"author": "NatoBoram",
"headCommitOid": "577cd483afb0be912f8869570688ef6e0481abc8",
"mergeBaseOid": "fd29466c2c73b884725f82bcd00cecc44ed7114e",
"lastPushDate": "2024-06-19T19:23:32.000Z",
"lastActivityDate": "2024-06-19T19:23:32.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "architect__functions",
"kind": "edit",
"files": [
{
"path": "types/architect__functions/test/http-tests.ts",
"kind": "test"
}
],
"owners": [
"activescott",
"ryanblock",
"reconbot"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "create-test-server",
"kind": "edit",
"files": [
{
"path": "types/create-test-server/create-test-server-tests.ts",
"kind": "test"
}
],
"owners": [
"midgleyc"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-brute-memcached",
"kind": "edit",
"files": [
{
"path": "types/express-brute-memcached/express-brute-memcached-tests.ts",
"kind": "test"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-brute-mongo",
"kind": "edit",
"files": [
{
"path": "types/express-brute-mongo/express-brute-mongo-tests.ts",
"kind": "test"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-brute",
"kind": "edit",
"files": [
{
"path": "types/express-brute/express-brute-tests.ts",
"kind": "test"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-oauth-server",
"kind": "edit",
"files": [
{
"path": "types/express-oauth-server/express-oauth-server-tests.ts",
"kind": "test"
}
],
"owners": [
"atd-schubert"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-serve-static-core",
"kind": "edit",
"files": [
{
"path": "types/express-serve-static-core/express-serve-static-core-tests.ts",
"kind": "test"
},
{
"path": "types/express-serve-static-core/index.d.ts",
"kind": "definition"
},
{
"path": "types/express-serve-static-core/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"borisyankov",
"micksatana",
"JoseLion",
"dwrss",
"andoshin11"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "express-ua-middleware",
"kind": "edit",
"files": [
{
"path": "types/express-ua-middleware/express-ua-middleware-tests.ts",
"kind": "test"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "feathersjs__express",
"kind": "edit",
"files": [
{
"path": "types/feathersjs__express/feathersjs__express-tests.ts",
"kind": "test"
}
],
"owners": [
"j2L4e",
"DadUndead"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "forest-express-mongoose",
"kind": "edit",
"files": [
{
"path": "types/forest-express-mongoose/forest-express-mongoose-tests.ts",
"kind": "test"
}
],
"owners": [
"SteveBunlon",
"ghusse"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "forest-express-sequelize",
"kind": "edit",
"files": [
{
"path": "types/forest-express-sequelize/forest-express-sequelize-tests.ts",
"kind": "test"
}
],
"owners": [
"SteveBunlon",
"ghusse"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "fusebit__oauth-connector",
"kind": "edit",
"files": [
{
"path": "types/fusebit__oauth-connector/fusebit__oauth-connector-tests.ts",
"kind": "test"
}
],
"owners": [
"andrewrmiller",
"hashiphoto",
"andydam"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "logfmt",
"kind": "edit",
"files": [
{
"path": "types/logfmt/logfmt-tests.ts",
"kind": "test"
}
],
"owners": [
"ebroder"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mock-req-res",
"kind": "edit",
"files": [
{
"path": "types/mock-req-res/mock-req-res-tests.ts",
"kind": "test"
}
],
"owners": [
"sandorTuranszky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mongoose-aggregate-paginate-v2",
"kind": "edit",
"files": [
{
"path": "types/mongoose-aggregate-paginate-v2/mongoose-aggregate-paginate-v2-tests.ts",
"kind": "test"
}
],
"owners": [
"acrilex1"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "swaggerize-express",
"kind": "edit",
"files": [
{
"path": "types/swaggerize-express/swaggerize-express-tests.ts",
"kind": "test"
}
],
"owners": [
"mugeso",
"nickmorton"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2179349816,
"ciResult": "unknown"
} |
|
🔔 @activescott @ryanblock @reconbot @midgleyc @cyrilschumacher @atd-schubert @borisyankov @micksatana @JoseLion @dwrss @andoshin11 @peterblazejewicz @j2L4e @DadUndead @SteveBunlon @ghusse @andrewrmiller @Hashiphoto @andydam @ebroder @sandorTuranszky @acrilex1 @MugeSo @nickmorton — please review this PR in the next few days. Be sure to explicitly select |
|
@NatoBoram The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@NatoBoram The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
|
|
we really need the types for |
|
I had a very hard time following the steps for a migration path to v5 before its release - maybe it's gotten easier now that it's released? You should have a go at it, I'm having some COVID at the moment. |
|
Alternative PR with all tests passing is here: #70563 |
|
4 participants
@typescript-eslint/no-misused-promisesto@types/express-serve-static-core's ESLint configvoid(and nowvoid | Promise<void>)Promise<void>toRequestHandler's return type #69660 (comment)