[@types/ember__helper] Fix failing test in 5.5#69838
[@types/ember__helper] Fix failing test in 5.5#69838jakebailey merged 3 commits intoDefinitelyTyped:masterfrom
Conversation
|
@jakebailey Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69838,
"author": "jakebailey",
"headCommitOid": "ac111daaa5877cb3720050f56c5a2d1240669eba",
"mergeBaseOid": "5ebe98afa6ecb3f54649f75636aa4bbd67dedce3",
"lastPushDate": "2024-06-18T20:32:57.000Z",
"lastActivityDate": "2024-06-18T20:56:05.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "ember__helper",
"kind": "edit",
"files": [
{
"path": "types/ember__helper/ember__helper-tests.ts",
"kind": "test"
}
],
"owners": [
"gitKrystan",
"jamescdavis",
"wagenet"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2176958012,
"ciResult": "pass"
} |
|
🔔 @gitKrystan @jamescdavis @wagenet — please review this PR in the next few days. Be sure to explicitly select |
|
@jakebailey The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
2 participants
This test has long been failing; update it so it passes.