Skip to content

[better-sqlite3] Add VirtualTableOptions rows params #69833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Jul 2, 2024
Merged

[better-sqlite3] Add VirtualTableOptions rows params #69833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bedd4
Add VirtualTableOptions rows params
cooolbros Jun 18, 2024
1f1d12c
Rename variable
cooolbros Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions types/better-sqlite3/better-sqlite3-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ db.table("vtable", {
yield { name: "testName" };
},
});
db.table("vtable_parameters", {
parameters: ["name"],
columns: ["name"],
*rows(name) {
yield { name: name };
},
});
db.function("noop", () => {});
db.function("noop", {
deterministic: true,
Expand Down Expand Up @@ -54,6 +61,9 @@ db.defaultSafeIntegers(true);
const vtable: Sqlite.Statement = db.prepare("SELECT * FROM vtable");
vtable.all();

const vtable_parameters: Sqlite.Statement = db.prepare("SELECT * FROM vtable_parameters('testName')");
vtable_parameters.all();

interface TypedParameter {
search: string;
}
Expand Down
2 changes: 1 addition & 1 deletion types/better-sqlite3/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ declare namespace BetterSqlite3 {
}

interface VirtualTableOptions {
rows: () => Generator;
rows: (...params: unknown[]) => Generator;
columns: string[];
parameters?: string[] | undefined;
safeIntegers?: boolean | undefined;
Expand Down