Skip to content

Update @types/bun to 1.1.13 #69794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
typescript-bot merged 1 commit into from
Jun 13, 2024
Merged

Update @types/bun to 1.1.13 #69794

typescript-bot merged 1 commit into from
Jun 13, 2024

Conversation

@Electroid
Copy link
Contributor

@Electroid Electroid commented Jun 12, 2024 •
edited
Loading

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2024 •
edited
Loading

@Electroid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 69794,
  "author": "Electroid",
  "headCommitOid": "eb4b7304211f3eb087f76aae99e2b8c58dea69d3",
  "mergeBaseOid": "49ff53280609f1437f35101c89c38f33a5c9fc8d",
  "lastPushDate": "2024-06-12T18:11:48.000Z",
  "lastActivityDate": "2024-06-13T03:26:44.000Z",
  "mergeOfferDate": "2024-06-12T21:13:25.000Z",
  "mergeRequestDate": "2024-06-13T03:26:44.000Z",
  "mergeRequestUser": "Jarred-Sumner",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "bun",
      "kind": "edit",
      "files": [
        {
          "path": "types/bun/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "colinhacks",
        "Jarred-Sumner",
        "electroid",
        "paperdave",
        "robobun",
        "dylan-conway"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Jarred-Sumner",
      "date": "2024-06-12T21:12:46.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2163637626,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels Jun 12, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2024

🔔 @colinhacks @Jarred-Sumner @paperdave @robobun @dylan-conway — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@Jarred-Sumner
Copy link
Contributor

Jarred-Sumner commented Jun 12, 2024

Approve

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 12, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2024

@Electroid: Everything looks good here. I am ready to merge this PR (at eb4b730) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@colinhacks, @Jarred-Sumner, @paperdave, @robobun, @dylan-conway: you can do this too.)

@Jarred-Sumner
Copy link
Contributor

Jarred-Sumner commented Jun 13, 2024

Ready to merge

@typescript-bot typescript-bot merged commit e050809 into DefinitelyTyped:master Jun 13, 2024
@calebamiles calebamiles mentioned this pull request Jun 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jarred-Sumner Jarred-Sumner Jarred-Sumner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Electroid @typescript-bot @Jarred-Sumner