Skip to content

[gamedig] fix import when using moduleResolution: node16 #69767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 8 commits into from
Jun 25, 2024
Merged

[gamedig] fix import when using moduleResolution: node16 #69767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09865f4
[gamedig] fix import when using `moduleResolution: node16`
a-sync Jun 9, 2024
26d7e5a
fix attempt #2
a-sync Jun 9, 2024
955e953
add `username` option (Palworld)
a-sync Jun 15, 2024
9bb2712
add palworld fields to tests
a-sync Jun 15, 2024
c5dc007
add moduleResolution: node16 to tsconfig
a-sync Jun 20, 2024
3477f5c
only set module and not moduleResolution
a-sync Jun 20, 2024
c80dc8b
add new owner: a-sync
a-sync Jun 25, 2024
dbff393
use strings to test palworld specific types
a-sync Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions types/gamedig/gamedig-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ gamedig.GameDig.query(
requestPlayersRequired: true,
checkOldIDs: true,
// checkAlias: true,
username: "admin",
password: "mypass",
},
(error: any, state: gamedig.QueryResult) => {
if (error) throw error;
Expand Down Expand Up @@ -48,6 +50,8 @@ gd.query(
requestPlayersRequired: true,
checkOldIDs: true,
// checkAlias: true,
username: "admin",
password: "mypass",
},
(error: any, state: gamedig.QueryResult) => {
if (error) throw error;
Expand Down
3 changes: 3 additions & 0 deletions types/gamedig/index.d.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,14 @@ export interface QueryOptions {
guildId?: string;
// Nadeo
login?: string;
// Nadeo / Palworld
password?: string;
// Teamspeak 3
teamspeakQueryPort?: number;
// Terraria
token?: string;
// Palworld
username?: string;
}

export interface QueryResult {
Expand Down
16 changes: 14 additions & 2 deletions types/gamedig/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,22 @@
{
"name": "Joshua Schmeder",
"githubUsername": "MaximumWoahverdrive"
},
{
"name": "a-sync",
"githubUsername": "a-sync"
}
],
"exports": {
"import": "./index.d.ts",
"require": "./index.d.cts"
".": {
"import": {
"types": "./index.d.ts",
"default": "./index.js"
},
"require": {
"types": "./index.d.cts",
"default": "./index.cjs"
}
}
}
}
2 changes: 1 addition & 1 deletion types/gamedig/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"module": "commonjs",
"module": "node16",
Copy link
Contributor

@MaximumWoahverdrive MaximumWoahverdrive Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for using node16 specifically?
I have no inherent issue with this, just curious.

Copy link
Contributor Author

@a-sync a-sync Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original issue was that the types didnt work with moduleResolution: node16: gamedig/node-gamedig#569

and the config was changed here to have a test for it:
#69767 (comment)

"target": "es6",
"lib": [
"es6"
Expand Down