@petercpwong Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• set-cookie-parser — on npm, on unpkg
  • owner-approval: @peterblazejewicz

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 69734,
  "author": "petercpwong",
  "headCommitOid": "d80f63e8ce74d9c99d194b384aa432aae7f1e404",
  "mergeBaseOid": "aaf94a0a6431f52c46dab26182f1156d79720d29",
  "lastPushDate": "2024-06-03T18:28:32.000Z",
  "lastActivityDate": "2024-06-12T08:07:34.000Z",
  "mergeOfferDate": "2024-06-11T20:42:32.000Z",
  "mergeRequestDate": "2024-06-12T08:07:34.000Z",
  "mergeRequestUser": "petercpwong",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "set-cookie-parser",
      "kind": "edit",
      "files": [
        {
          "path": "types/set-cookie-parser/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/set-cookie-parser/set-cookie-parser-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "nickp10",
        "singlebyted",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-06-11T20:41:55.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "nickp10",
      "date": "2024-06-03T18:36:26.000Z",
      "abbrOid": "58e6407"
    }
  ],
  "mainBotCommentID": 2145859702,
  "ciResult": "pass"
}

🔔 @nickp10 @singlebyted @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@petercpwong The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

⏳ Hi @petercpwong,

It's been a few days since this PR was approved by peterblazejewicz, nickp10 and we're waiting for you to fix the test failures and then for a maintainer approval.

If you would like to short-circuit another wait for a maintainer, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@petercpwong The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Formatting

The following files are not formatted:

1. types/set-cookie-parser/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against d80f63e

@peterblazejewicz, @nickp10 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@nickp10 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Ready to merge

Note that this change to the type doesn't actually reflect runtime behavior, as the result of setCookie.parse(setCookie.splitCookiesString(header)) will happily contain uppercase Strict and such, and in fact almost definitely will because the uppercase header values are what's actually documented and defined in the cookies standard (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie, https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis#section-4.1.1). This change should be reverted.