node: Add missing spaces#69714
node: Add missing spaces#69714typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom J-295:master
Conversation
|
@J-295 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69714,
"author": "J-295",
"headCommitOid": "440fc8ae291ded1380126131dfb1800dfba6f40b",
"mergeBaseOid": "aaf94a0a6431f52c46dab26182f1156d79720d29",
"lastPushDate": "2024-05-31T15:49:07.000Z",
"lastActivityDate": "2024-06-03T23:11:02.000Z",
"mergeOfferDate": "2024-06-03T21:12:53.000Z",
"mergeRequestDate": "2024-06-03T23:11:02.000Z",
"mergeRequestUser": "J-295",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/util.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-06-03T21:12:16.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2142538300,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
Hey @J-295, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
I was originally planning to only do the changes in my first commit, but I am now finished. |
typescript-bot
added
the
Has Merge Conflict
|
@J-295 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
The bot says there is a merge conflict yet to me it says there are none. |
typescript-bot
removed
the
Has Merge Conflict
|
Remove the changes for v20 I have included those and even more of these spacing problems in #69719 |
typescript-bot
added
Maintainer Approved
Self Merge
|
Ready to merge |
typescript-bot
added
Has Merge Conflict
|
🛂 Hi @J-295, I can't accept a pull request until all of the checks in the "Status" section of this comment are green. I will let you know once that happens. Thanks, and happy typing! |
typescript-bot
removed
Has Merge Conflict
|
🛂 Hi @J-295, I can't accept a pull request until all of the checks in the "Status" section of this comment are green. I will let you know once that happens. Thanks, and happy typing! |
|
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
typescript-bot
added
Maintainer Approved
Self Merge
|
@J-295: Everything looks good here. I am ready to merge this PR (at 440fc8a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
3 participants
Add missing spaces in lists of single-line code blocks.