Skip to content

Add template import type for uniqueId helper #69687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jun 27, 2024
Merged

Add template import type for uniqueId helper #69687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion types/ember__helper/ember__helper-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { array, capabilities, concat, fn, get, hash, invokeHelper, setHelperManager } from "@ember/helper";
import { array, capabilities, concat, fn, get, hash, invokeHelper, setHelperManager, uniqueId } from "@ember/helper";

array; // $ExpectType ArrayHelper
concat; // $ExpectType ConcatHelper
fn; // $ExpectType FnHelper
get; // $ExpectType GetHelper
hash; // $ExpectType HashHelper
uniqueId; // $ExpectType UniqueIdHelper
invokeHelper; // $ExpectType (context: object, definition: object, computeArgs?: ((context: object) => Partial<Arguments>) | undefined) => Cache<unknown>
capabilities; // $ExpectType <O extends object, T extends object>(factory: ManagerFactory<O | undefined, HelperManager<unknown>>, obj: T) => T
setHelperManager; // $ExpectType <O extends object, T extends object>(factory: ManagerFactory<O | undefined, HelperManager<unknown>>, obj: T) => T
9 changes: 9 additions & 0 deletions types/ember__helper/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface ConcatHelper extends Opaque<"helper:concat"> {}
export interface FnHelper extends Opaque<"helper:fn"> {}
export interface GetHelper extends Opaque<"helper:get"> {}
export interface HashHelper extends Opaque<"helper:hash"> {}
export interface UniqueIdHelper extends Opaque<"helper:unique-id"> {}

/**
* Use the `{{array}}` helper to create an array to pass as an option to your components.
Expand Down Expand Up @@ -49,6 +50,14 @@ export const get: GetHelper;
*/
export const hash: HashHelper;

/**
* Use the `{{unique-id}}` helper to generate a unique ID string suitable for use as an ID
* attribute in the DOM.
*
* @see https://api.emberjs.com/ember/release/classes/Ember.Templates.helpers/methods/unique-id?anchor=unique-id
*/
export const uniqueId: UniqueIdHelper

/**
`capabilities` returns a capabilities configuration which can be used to modify
the behavior of the manager. Manager capabilities _must_ be provided using the
Expand Down