[markdown-it]: specify dependency versions on markdown-it v13#69492
[markdown-it]: specify dependency versions on markdown-it v13#69492typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@brc-dd Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69492,
"author": "brc-dd",
"headCommitOid": "d7e4659c979b1305402c990c52b841eba3aeeece",
"mergeBaseOid": "fd02d699d8f81052a5c9bf95555b86ac8e7ddc8b",
"lastPushDate": "2024-05-01T20:11:53.000Z",
"lastActivityDate": "2024-05-01T20:21:54.000Z",
"mergeOfferDate": "2024-05-01T20:20:33.000Z",
"mergeRequestDate": "2024-05-01T20:21:54.000Z",
"mergeRequestUser": "brc-dd",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "markdown-it-emoji",
"kind": "edit",
"files": [
{
"path": "types/markdown-it-emoji/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Shinigami92",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "markdown-it",
"kind": "edit",
"files": [
{
"path": "types/markdown-it/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/markdown-it/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/markdown-it/v13/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/markdown-it/v13/index.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/common/entities.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/common/html_blocks.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/common/html_re.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/common/utils.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/helpers/index.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/helpers/parse_link_destination.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/helpers/parse_link_label.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/helpers/parse_link_title.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/index.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/parser_block.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/parser_core.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/parser_inline.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/renderer.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/ruler.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/rules_block/state_block.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/rules_core/state_core.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/rules_inline/state_inline.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/lib/token.d.ts",
"kind": "definition"
},
{
"path": "types/markdown-it/v13/markdown-it-tests.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/markdown-it/v13/test/common/utils.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/helpers/index.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/index.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/parser_block.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/parser_core.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/parser_inline.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/renderer.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/ruler.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/rules_block/state_block.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/rules_core/state_core.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/rules_inline/state_inline.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/test/token.ts",
"kind": "test"
},
{
"path": "types/markdown-it/v13/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"plantain-00",
"rapropos",
"duduluu",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-05-01T20:20:00.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2089061317,
"ciResult": "pass"
} |
|
🔔 @Shinigami92 @peterblazejewicz @plantain-00 @rapropos @duduluu — please review this PR in the next few days. Be sure to explicitly select |
|
@brc-dd The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
| "@types/linkify-it": "^5", | ||
| "@types/mdurl": "^2" |
There was a problem hiding this comment.
These look correct to me given upstream's dependencies. https://unpkg.com/[email protected]/package.json
| "https://github.com/markdown-it/markdown-it" | ||
| ], | ||
| "dependencies": { | ||
| "@types/linkify-it": "^3", |
There was a problem hiding this comment.
This should be ^4, given https://unpkg.com/[email protected]/package.json says linkify-it at 4.
There was a problem hiding this comment.
There are no types corresponding to v4 - https://www.npmjs.com/package/@types/linkify-it?activeTab=versions
There was a problem hiding this comment.
Bleh, okay. I guess the other PR jumped right to 5.
There was a problem hiding this comment.
v4 didn't have any type changes though - https://github.com/markdown-it/linkify-it/blob/master/CHANGELOG.md except added matchAtStart maybe 👀
typescript-bot
added
Maintainer Approved
Self Merge
1 similar comment
|
Ready to merge |
3 participants
Please fill in this template.
refer #69355
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.