[@types/node] Dirent.path is renamed to Dirent.parentPath#69490
[@types/node] Dirent.path is renamed to Dirent.parentPath#69490typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@JLHwung Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69490,
"author": "JLHwung",
"headCommitOid": "79579acadcf0177ebd2239b2af655a37af3412ae",
"mergeBaseOid": "5ffffd80f639d121df1903bf2a13a62f01cac640",
"lastPushDate": "2024-05-01T19:08:45.000Z",
"lastActivityDate": "2024-05-08T11:37:54.000Z",
"mergeOfferDate": "2024-05-06T20:29:34.000Z",
"mergeRequestDate": "2024-05-08T11:37:54.000Z",
"mergeRequestUser": "Semigradsky",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v18/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/fs.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-05-06T20:28:55.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Semigradsky",
"date": "2024-05-06T18:58:10.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "Anonymous4078",
"date": "2024-05-06T15:38:22.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2088943720,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Other Approved
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@JLHwung: Everything looks good here. I am ready to merge this PR (at 79579ac) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
ghost
mentioned this pull request
5 participants
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition: