[@types/fs-readdir-recursive] Complete typings#69489
Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom May 1, 2024
Merged
[@types/fs-readdir-recursive] Complete typings#69489typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@JLHwung Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69489,
"author": "JLHwung",
"headCommitOid": "cbb0029345ecfe350ed7a77bb9f40c95273ad533",
"mergeBaseOid": "5ffffd80f639d121df1903bf2a13a62f01cac640",
"lastPushDate": "2024-05-01T18:40:23.000Z",
"lastActivityDate": "2024-05-01T19:27:32.000Z",
"mergeOfferDate": "2024-05-01T19:25:36.000Z",
"mergeRequestDate": "2024-05-01T19:27:32.000Z",
"mergeRequestUser": "pscanf",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "fs-readdir-recursive",
"kind": "edit",
"files": [
{
"path": "types/fs-readdir-recursive/fs-readdir-recursive-tests.ts",
"kind": "test"
},
{
"path": "types/fs-readdir-recursive/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pscanf"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "pscanf",
"date": "2024-05-01T19:24:57.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2088904126,
"ciResult": "pass"
} |
Contributor
|
🔔 @pscanf — please review this PR in the next few days. Be sure to explicitly select |
JLHwung
force-pushed
the
improve-fs-readdir-recursive
branch
from
6cd6a4a to
cbb0029
Compare
pscanf
approved these changes
May 1, 2024
typescript-bot
added
Owner Approved
Contributor
Contributor
|
Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
The previous definition was missing the third and the fourth parameter. Spot this issue when I am working on a Babel PR https://github.com/babel/babel/pull/16459/files#r1586574307