Skip to content

[kap-plugin] Use correct version of electron-store#69486

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:kap-plugin
May 1, 2024
Merged

[kap-plugin] Use correct version of electron-store#69486
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:kap-plugin

Conversation

@jakebailey
Copy link
Copy Markdown
Member

CI says:

Error in kap-plugin
Error: 
/home/runner/work/DefinitelyTyped/DefinitelyTyped/types/kap-plugin/index.d.ts
  33:13  error  [email protected], 4.8, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4, 5.5 compile error: 
Cannot use namespace 'ElectronStore' as a type  @definitelytyped/expect

/home/runner/work/DefinitelyTyped/DefinitelyTyped/types/kap-plugin/kap-plugin-tests.ts
  24:9  error  [email protected], 4.8, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4, 5.5 expected type to be:
  string
got:
  any  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

This is blocking #69212.

The actual version of electron-store should be v7, not >=8: https://github.com/wulkano/Kap/blob/c42692fa63ac71ed192e01684beb78a1b864aa88/package.json#L50

The >=8 was added in #60932.

@jakebailey jakebailey requested review from rbuckton and sandersn May 1, 2024 17:21
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 1, 2024

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69486,
  "author": "jakebailey",
  "headCommitOid": "cf5956238b10c086c57ae5382108fff84fd778bf",
  "mergeBaseOid": "6e34ae8a215717aef8869e90dee72bbadcb0728d",
  "lastPushDate": "2024-05-01T17:21:31.000Z",
  "lastActivityDate": "2024-05-01T17:25:26.000Z",
  "mergeOfferDate": "2024-05-01T17:25:14.000Z",
  "mergeRequestDate": "2024-05-01T17:25:21.000Z",
  "mergeRequestUser": "jakebailey",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "kap-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/kap-plugin/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/kap-plugin/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "connor4312"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "connor4312",
      "date": "2024-05-01T17:25:26.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-01T17:24:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2088798765,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label May 1, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @jakebailey,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @connor4312 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 1, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@jakebailey: Everything looks good here. I am ready to merge this PR (at cf59562) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@connor4312: you can do this too.)

1 similar comment
@typescript-bot
Copy link
Copy Markdown
Contributor

@jakebailey: Everything looks good here. I am ready to merge this PR (at cf59562) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@connor4312: you can do this too.)

@jakebailey
Copy link
Copy Markdown
Member Author

Ready to merge

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 1, 2024
@typescript-bot typescript-bot merged commit 0f5b635 into DefinitelyTyped:master May 1, 2024
@jakebailey jakebailey deleted the kap-plugin branch May 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants