Skip to content

Fix errors related to new RegExp syntax checking#69485

Merged
rbuckton merged 1 commit intomasterfrom
checked-regexp-fixes
May 1, 2024
Merged

Fix errors related to new RegExp syntax checking#69485
rbuckton merged 1 commit intomasterfrom
checked-regexp-fixes

Conversation

@rbuckton
Copy link
Copy Markdown
Collaborator

@rbuckton rbuckton commented May 1, 2024

This fixes two tests that are failing due to the new RegExp syntax checking feature.

@rbuckton rbuckton requested a review from jakebailey May 1, 2024 16:53
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 1, 2024

@rbuckton Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • 🕐 Continuous integration tests are still running
  • ✅ A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69485,
  "author": "rbuckton",
  "headCommitOid": "588bcd0e941da54ad60f780b3f6824ed6cf4cda0",
  "mergeBaseOid": "8bcc2b08a817347b2e76dc91c605409e7ea60870",
  "lastPushDate": "2024-05-01T16:53:03.000Z",
  "lastActivityDate": "2024-05-01T16:55:38.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "regexp.prototype.flags",
      "kind": "edit",
      "files": [
        {
          "path": "types/regexp.prototype.flags/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.target`)"
        }
      ],
      "owners": [
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "webpack-manifest-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/webpack-manifest-plugin/webpack-manifest-plugin-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "r3nya",
        "monsonjeremy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ljharb",
      "date": "2024-05-01T16:55:38.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-05-01T16:55:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2088759835,
  "ciResult": "unknown"
}

@typescript-bot typescript-bot added Edits multiple packages Check Config Changes a module config files labels May 1, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @ljharb @r3nya @monsonjeremy — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Maintainer Approved labels May 1, 2024
@rbuckton rbuckton merged commit 6e34ae8 into master May 1, 2024
@rbuckton rbuckton deleted the checked-regexp-fixes branch May 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check Config Changes a module config files Edits multiple packages Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants