fix(pngjs): add re-export for browser usage#69467
fix(pngjs): add re-export for browser usage#69467typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
As per DefinitelyTyped#69449, this adds re-export to use documented 'pngjs/browser'. Thanks! /cc @moritz-t-w Fixes DefinitelyTyped#69449
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69467,
"author": "peterblazejewicz",
"headCommitOid": "4c0e95956fe5898bbbcc29aebb42861c2e75b5a5",
"mergeBaseOid": "0474990ae3c1b3745cc7bd6dd83f69c2f574f4de",
"lastPushDate": "2024-04-29T19:30:12.000Z",
"lastActivityDate": "2024-05-02T19:24:57.000Z",
"mergeOfferDate": "2024-04-30T18:59:35.000Z",
"mergeRequestDate": "2024-05-02T19:24:57.000Z",
"mergeRequestUser": "peterblazejewicz",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "pngjs",
"kind": "edit",
"files": [
{
"path": "types/pngjs/browser.d.ts",
"kind": "definition"
},
{
"path": "types/pngjs/pngjs-tests.ts",
"kind": "test"
}
],
"owners": [
"jason0x43",
"ffflorian",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "ffflorian",
"date": "2024-04-30T18:58:54.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2083507948,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
🔔 @jason0x43 @ffflorian — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Owner Approved
|
@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at 4c0e959) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@jason0x43, @ffflorian: you can do this too.) |
|
Ready to merge |
4 participants
As per #69449, this adds re-export to use documented 'pngjs/browser'.
Thanks!
/cc @moritz-t-w
Fixes #69449