Skip to content

[luxon-business-days] New type definitions#69446

Merged
typescript-bot merged 9 commits intoDefinitelyTyped:masterfrom
bcbailey:luxon-business-days
May 2, 2024
Merged

[luxon-business-days] New type definitions#69446
typescript-bot merged 9 commits intoDefinitelyTyped:masterfrom
bcbailey:luxon-business-days

Conversation

@bcbailey
Copy link
Copy Markdown
Contributor

@bcbailey bcbailey commented Apr 25, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 25, 2024 •
edited
Loading

@bcbailey Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 69446,
  "author": "bcbailey",
  "headCommitOid": "7bce14e3227989551ca252d24c0fa4b45b5fac4e",
  "mergeBaseOid": "6774861928eff924ba8af18823187c9417bd739e",
  "lastPushDate": "2024-04-25T22:21:12.000Z",
  "lastActivityDate": "2024-05-02T19:27:07.000Z",
  "mergeOfferDate": "2024-05-02T19:25:15.000Z",
  "mergeRequestDate": "2024-05-02T19:27:07.000Z",
  "mergeRequestUser": "bcbailey",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "luxon-business-days",
      "kind": "add",
      "files": [
        {
          "path": "types/luxon-business-days/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/luxon-business-days/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/luxon-business-days/luxon-business-days-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/luxon-business-days/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/luxon-business-days/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "bcbailey"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-05-02T19:24:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2078268796,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Apr 25, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 25, 2024

🔔 @bcbailey — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@bcbailey bcbailey mentioned this pull request Apr 25, 2024
Open
peterblazejewicz
peterblazejewicz reviewed Apr 30, 2024
View reviewed changes
Comment thread types/luxon-business-days/index.d.ts Outdated
peterblazejewicz
peterblazejewicz approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bcbailey thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 30, 2024
@typescript-bot typescript-bot removed Self Merge This PR can now be self-merged by the PR author or an owner Maintainer Approved labels Apr 30, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 30, 2024

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 2, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 2, 2024

@bcbailey: Everything looks good here. I am ready to merge this PR (at 7bce14e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@bcbailey
Copy link
Copy Markdown
Contributor Author

bcbailey commented May 2, 2024

Ready to merge

@typescript-bot typescript-bot merged commit f41cce3 into DefinitelyTyped:master May 2, 2024
@bcbailey bcbailey deleted the luxon-business-days branch May 2, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterblazejewicz peterblazejewicz peterblazejewicz approved these changes

Assignees

No one assigned

Labels

Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bcbailey @typescript-bot @peterblazejewicz