[webrtc] update for TS 5.5#69424
Merged
jakebailey merged 1 commit intoDefinitelyTyped:masterfrom May 1, 2024
Merged
Conversation
Contributor
|
@iisaduan Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69424,
"author": "iisaduan",
"headCommitOid": "af334ee871919c3f3e16c6d635c16682d230018e",
"mergeBaseOid": "e146f73a878fead2d32e03721e2dce2e5d0b8a71",
"lastPushDate": "2024-04-23T22:53:58.000Z",
"lastActivityDate": "2024-05-01T15:25:48.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "webrtc",
"kind": "edit",
"files": [
{
"path": "types/webrtc/RTCPeerConnection.d.ts",
"kind": "definition"
},
{
"path": "types/webrtc/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/webrtc/ts5.4/MediaStream.d.ts",
"kind": "definition"
},
{
"path": "types/webrtc/ts5.4/RTCPeerConnection.d.ts",
"kind": "definition"
},
{
"path": "types/webrtc/ts5.4/index.d.ts",
"kind": "definition"
},
{
"path": "types/webrtc/ts5.4/test/MediaStream.ts",
"kind": "test"
},
{
"path": "types/webrtc/ts5.4/test/RTCPeerConnection.ts",
"kind": "test"
},
{
"path": "types/webrtc/ts5.4/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.strictFunctionTypes`)"
}
],
"owners": [
"nakakura"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-05-01T15:25:48.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2073610744,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
Contributor
|
🔔 @nakakura — please review this PR in the next few days. Be sure to explicitly select |
jakebailey
approved these changes
May 1, 2024
typescript-bot
added
Maintainer Approved
Self Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
RTCIceCandidatePairto have non-optional properties in 5.5 as updated here: src/lib/dom.generated.d.tsIf changing an existing definition: