[@types/emscripten] Added analyzePath, updated Module.instantiateWasm#69386
Merged
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom May 1, 2024
mattfysh:master
Merged
[@types/emscripten] Added analyzePath, updated Module.instantiateWasm#69386typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom mattfysh:master
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
mattfysh:master
Conversation
Contributor
|
@mattfysh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69386,
"author": "mattfysh",
"headCommitOid": "a66c745fe81f0b2505c89e62b40165bf3558b792",
"mergeBaseOid": "7c28187a1abdad59a6e044e19ce49a0f3905659a",
"lastPushDate": "2024-04-18T05:08:20.000Z",
"lastActivityDate": "2024-05-01T22:35:46.000Z",
"mergeOfferDate": "2024-05-01T18:54:24.000Z",
"mergeRequestDate": "2024-05-01T22:35:46.000Z",
"mergeRequestUser": "mattfysh",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "emscripten",
"kind": "edit",
"files": [
{
"path": "types/emscripten/emscripten-tests.ts",
"kind": "test"
},
{
"path": "types/emscripten/index.d.ts",
"kind": "definition"
},
{
"path": "types/emscripten/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"zakki",
"periklis",
"kbumsik",
"lourd"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-01T18:53:43.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2063003997,
"ciResult": "pass"
} |
Contributor
|
@mattfysh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69386,
"author": "mattfysh",
"headCommitOid": "a66c745fe81f0b2505c89e62b40165bf3558b792",
"mergeBaseOid": "7c28187a1abdad59a6e044e19ce49a0f3905659a",
"lastPushDate": "2024-04-18T05:08:20.000Z",
"lastActivityDate": "2024-05-01T22:35:46.000Z",
"mergeOfferDate": "2024-05-01T18:54:24.000Z",
"mergeRequestDate": "2024-05-01T22:35:46.000Z",
"mergeRequestUser": "mattfysh",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "emscripten",
"kind": "edit",
"files": [
{
"path": "types/emscripten/emscripten-tests.ts",
"kind": "test"
},
{
"path": "types/emscripten/index.d.ts",
"kind": "definition"
},
{
"path": "types/emscripten/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"zakki",
"periklis",
"kbumsik",
"lourd"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-01T18:53:43.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2063003997,
"ciResult": "pass"
} |
Contributor
|
🔔 @zakki @periklis @kbumsik @lourd — please review this PR in the next few days. Be sure to explicitly select |
mattfysh
changed the title
Contributor
typescript-bot
added
the
Unreviewed
rbuckton
approved these changes
May 1, 2024
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Author
|
Ready to merge |
thenick775
added a commit
to thenick775/mgba
that referenced
this pull request
May 16, 2024
thenick775
added a commit
to thenick775/mgba
that referenced
this pull request
May 16, 2024
thenick775
added a commit
to thenick775/mgba
that referenced
this pull request
May 16, 2024
thenick775
added a commit
to thenick775/mgba
that referenced
this pull request
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.