[@types/dockerode] Improve AuthConfig and pull() types#69385
[@types/dockerode] Improve AuthConfig and pull() types#69385typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@nwalters512 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69385,
"author": "nwalters512",
"headCommitOid": "0146e703b4200a19b08df61baabd8c2990205aca",
"mergeBaseOid": "c5bf4b3091b296f8cc7e810cfbf14e6864982a5b",
"lastPushDate": "2024-04-17T23:29:47.000Z",
"lastActivityDate": "2024-04-30T17:03:11.000Z",
"mergeOfferDate": "2024-04-30T10:13:35.000Z",
"mergeRequestDate": "2024-04-30T17:03:11.000Z",
"mergeRequestUser": "nwalters512",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "dockerode",
"kind": "edit",
"files": [
{
"path": "types/dockerode/dockerode-tests.ts",
"kind": "test"
},
{
"path": "types/dockerode/index.d.ts",
"kind": "definition"
}
],
"owners": [
"seikho",
"nlaplante",
"isac322",
"lazarusx",
"meisenzahl",
"thegecko",
"CameronDiver",
"p4sca1",
"stuartthomson",
"userlerueda"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "CameronDiver",
"date": "2024-04-30T10:12:55.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2062663723,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @stuartthomson @userlerueda — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @Seikho, @nlaplante, @isac322, @LazarusX, @meisenzahl, @thegecko, @CameronDiver, @P4sca1, @stuartthomson, @userlerueda: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
the
Unreviewed
typescript-bot
added
Owner Approved
|
@nwalters512: Everything looks good here. I am ready to merge this PR (at 0146e70) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Seikho, @nlaplante, @isac322, @LazarusX, @meisenzahl, @thegecko, @CameronDiver, @P4sca1, @stuartthomson, @userlerueda: you can do this too.) |
|
Ready to merge |
3 participants
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
AuthConfigcomes directly from the Docker source code: https://github.com/moby/moby/blob/b7c059886c0898436db90b4615a27cfb4d93ce34/api/types/registry/authconfig.go#L16-L34pull()reflects the fact thatpull()is just a wrapper aroundcreateImage()and will thus have the same return value: https://github.com/apocas/dockerode/blob/0a1e34cd0d30d492fe2c6078ae73e2002a698b5a/lib/docker.js#L1446-L1466package.json.