@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• oracledb — on npm, on unpkg
  • owner-approval: @jacobwheale

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 69379,
  "author": "codershiba",
  "headCommitOid": "7bc3f900cdade6ea64fa0188f4c0be79900ed1d7",
  "mergeBaseOid": "895d2be48edd77037fb8920161d109059d600002",
  "lastPushDate": "2024-04-17T10:59:43.000Z",
  "lastActivityDate": "2024-05-01T18:26:06.000Z",
  "mergeOfferDate": "2024-05-01T17:39:06.000Z",
  "mergeRequestDate": "2024-05-01T18:26:06.000Z",
  "mergeRequestUser": "codershiba",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648",
        "jacobwheale"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-01T17:38:26.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "jacobwheale",
      "date": "2024-04-23T08:16:01.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2060993246,
  "ciResult": "pass"
}

Hey @codershiba,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @connorjayfitzgerald @dannyb648 @jacobwheale — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

⏳ Hi @codershiba,

It's been a few days since this PR was approved by jacobwheale and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

Re-ping @connorjayfitzgerald, @dannyb648:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Looks good! Good catch!

@codershiba: Everything looks good here. I am ready to merge this PR (at 7bc3f90) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@connorjayfitzgerald, @dannyb648, @jacobwheale: you can do this too.)

Ready to merge