[react] Allow React context in ReactNode #69304
Conversation
eps1lon
force-pushed
the
react/render-context
branch
from
f80465a to
0c74888
Compare
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69304,
"author": "eps1lon",
"headCommitOid": "1ae65a016edfbcac117e4166a9b95d06322c03a5",
"mergeBaseOid": "554316568c0a5165fea45ab5acdfca93f421f36c",
"lastPushDate": "2024-04-08T21:19:42.000Z",
"lastActivityDate": "2024-04-08T22:23:38.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/test/experimental.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/test/experimental.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 2043740600,
"ciResult": "pass"
} |
1 similar comment
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69304,
"author": "eps1lon",
"headCommitOid": "1ae65a016edfbcac117e4166a9b95d06322c03a5",
"mergeBaseOid": "554316568c0a5165fea45ab5acdfca93f421f36c",
"lastPushDate": "2024-04-08T21:19:42.000Z",
"lastActivityDate": "2024-04-08T22:23:38.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/test/experimental.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/test/experimental.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 2043740600,
"ciResult": "pass"
} |
typescript-bot
added
The CI failed
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
1 similar comment
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
The CI failed
|
@eps1lon The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
1 similar comment
|
@eps1lon The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
eps1lon
force-pushed
the
react/render-context
branch
from
0c74888 to
def11fe
Compare
typescript-bot
added
Has Merge Conflict
|
@eps1lon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
eps1lon
force-pushed
the
react/render-context
branch
from
def11fe to
02404b6
Compare
typescript-bot
removed
the
Has Merge Conflict
React is not doing that either i.e. if you're given a `React.Node` it could be `createContext(createContext('a'))`.
typescript-bot
added
Where is GH Actions?
2 participants
CI failures are unrelated: #69307
Does not support nested context even though context values are recursively unwrapped at runtime where
{React.createContext(React.createContext('render me'))}should work.Modelling this with types is a bit more involved and practically probably not that relevant. We can work on it once we see legit use cases.
Also moved promise as a node to types for Canary release channel.