[readable-stream] remove deprecated tag from Duplex.from#69164
Conversation
|
@10xLaCroixDrinker Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69164,
"author": "10xLaCroixDrinker",
"headCommitOid": "6e8fd65163d9ee1e425c72f77205d97ecfcca848",
"mergeBaseOid": "f28fbd97b9fea22e6174db17652d91a94eb2006a",
"lastPushDate": "2024-03-25T16:03:57.000Z",
"lastActivityDate": "2024-05-02T20:23:34.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2024-05-02T20:10:35.000Z",
"mergeRequestDate": "2024-05-02T20:23:34.000Z",
"mergeRequestUser": "10xLaCroixDrinker",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "readable-stream",
"kind": "edit",
"files": [
{
"path": "types/readable-stream/index.d.ts",
"kind": "definition"
},
{
"path": "types/readable-stream/readable-stream-tests.ts",
"kind": "test"
}
],
"owners": [
"TeamworkGuy2",
"markdreyer"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-02T20:09:54.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2018359051,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @TeamworkGuy2 @markdreyer — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Unreviewed
|
Re-ping @TeamworkGuy2, @markdreyer: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @10xLaCroixDrinker. (Ping @TeamworkGuy2, @markdreyer.) |
typescript-bot
added
Maintainer Approved
Self Merge
|
@10xLaCroixDrinker: Everything looks good here. I am ready to merge this PR (at 6e8fd65) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@TeamworkGuy2, @markdreyer: you can do this too.) |
|
Ready to merge |
4 participants
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
These were marked deprecated/never because readable-stream did not support them, but they've had parity with Node 18 since 4.0.0
Related nodejs/readable-stream#534
package.json.