Skip to content

[react] Remove Readonly<P> from class component constructor #69140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Mar 25, 2024
Merged

[react] Remove Readonly<P> from class component constructor #69140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12df4a5
[react] Add test highlighting the `Readonly` in the constructor signa…
eps1lon Mar 23, 2024
d6ea30e
[react] Remove Readonly<P> from class component constructor
eps1lon Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ declare namespace React {
*/
context: unknown;

constructor(props: Readonly<P> | P);
constructor(props: P);
/**
* @deprecated
* @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}
Expand Down
15 changes: 15 additions & 0 deletions types/react/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ declare const container: Element;
}
}
class BetterPropsAndStateChecksComponent extends React.Component<Props, State, Snapshot> {
constructor(props: Props) {
super(props);
// This should ideally error since `props` should not be mutated, but it doesn't.
props.foo = 2;
// @ts-expect-error
this.props = { type: "foo" };
}

render() {
return null;
}
Expand Down Expand Up @@ -117,6 +125,13 @@ declare const container: Element;
};
}
}

class InferredConstructorProps extends React.Component<{ value: string }> {
// @ts-expect-error ts(7006) Ideally, this would infer the props type from the type parameter but has implicit any.
constructor(props) {
super(props);
}
}
}

class ModernComponent extends React.Component<Props, State, Snapshot>
Expand Down
2 changes: 1 addition & 1 deletion types/react/ts5.0/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ declare namespace React {
*/
context: unknown;

constructor(props: Readonly<P> | P);
constructor(props: P);
/**
* @deprecated
* @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}
Expand Down
15 changes: 15 additions & 0 deletions types/react/ts5.0/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ declare const container: Element;
}
}
class BetterPropsAndStateChecksComponent extends React.Component<Props, State, Snapshot> {
constructor(props: Props) {
super(props);
// This should ideally error since `props` should not be mutated, but it doesn't.
props.foo = 2;
// @ts-expect-error
this.props = { type: "foo" };
}

render() {
return null;
}
Expand Down Expand Up @@ -117,6 +125,13 @@ declare const container: Element;
};
}
}

class InferredConstructorProps extends React.Component<{ value: string }> {
// @ts-expect-error ts(7006) Ideally, this would infer the props type from the type parameter but has implicit any.
constructor(props) {
super(props);
}
}
}

class ModernComponent extends React.Component<Props, State, Snapshot>
Expand Down