Remove `@wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated}` types due to bundled definitions in packages #69133

rafaucau · 2024-03-23T13:51:05Z

This PR removes types that are already bundled in the packages.

Resolves: #64541

typescript-bot · 2024-03-23T14:26:23Z

@rafaucau Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

13 packages in this PR (and infra files)

wordpress__block-editor — on npm, on unpkg
wordpress__block-serialization-default-parser (probably deleted!) — on npm, on unpkg
wordpress__blocks — on npm, on unpkg
wordpress__components (probably deleted!) — on npm, on unpkg
- owner-approval: @sarayourfriend
- Config files to check:
  - wordpress__components/.eslintrc.json: edited
wordpress__date (probably deleted!) — on npm, on unpkg
wordpress__deprecated (probably deleted!) — on npm, on unpkg
wordpress__dom (probably deleted!) — on npm, on unpkg
wordpress__editor — on npm, on unpkg
wordpress__keycodes (probably deleted!) — on npm, on unpkg
wordpress__notices (probably deleted!) — on npm, on unpkg
wordpress__plugins (probably deleted!) — on npm, on unpkg
wordpress__redux-routine (probably deleted!) — on npm, on unpkg
wordpress__rich-text (probably deleted!) — on npm, on unpkg
- Config files to check:
  - wordpress__rich-text/.eslintrc.json: edited
Infra files
- notNeededPackages.json

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69133,
  "author": "rafaucau",
  "headCommitOid": "ec36d389668c9f2878c2ba071f5014290aac3229",
  "mergeBaseOid": "e1386bb7838c35504edfdb12876bf0d156d84a2a",
  "lastPushDate": "2024-03-23T13:51:05.000Z",
  "lastActivityDate": "2024-04-03T18:19:15.000Z",
  "mergeOfferDate": "2024-04-03T18:14:31.000Z",
  "mergeRequestDate": "2024-04-03T18:19:15.000Z",
  "mergeRequestUser": "rafaucau",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "wordpress__block-editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__block-editor/components/alignment-toolbar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/block-controls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/block-format-controls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/block-icon.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/font-sizes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/inserter.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/inspector-advanced-controls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/inspector-controls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/media-placeholder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/navigable-toolbar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/panel-color-settings.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/rich-text.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/components/url-popover.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__block-editor/wordpress__block-editor-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__block-serialization-default-parser",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__block-serialization-default-parser/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__block-serialization-default-parser/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-serialization-default-parser/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__block-serialization-default-parser/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__block-serialization-default-parser/wordpress__block-serialization-default-parser-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__blocks",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__blocks/api/categories.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__blocks/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__blocks/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell",
        "tomasztunik",
        "sunyatasattva",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__components",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__components/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/wordpress__components/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/angle-picker-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/animate/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/autocomplete/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/base-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/button-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/body/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/divider/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/footer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/header/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/media/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/checkbox-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/clipboard-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-indicator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-palette/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/combobox-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/custom-select-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dashicon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/date.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/time.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/disabled/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/draggable/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/drop-zone/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/drop-zone/provider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dropdown-menu/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dropdown/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/external-link/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/block.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/item.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/focal-point-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/focusable-iframe/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/font-size-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-file-upload/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-toggle/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-token-field/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/guide/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/navigate-regions/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-constrained-tabbing/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-fallback-styles/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-filters/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-focus-outside/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-focus-return/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-notices/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-spoken-messages/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/icon-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/icon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/isolated-event-container/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/keyboard-shortcuts/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-item/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-items-choice/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/modal/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/menu.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/tabbable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/notice/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/notice/list.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/panel/body.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/header.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/row.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/placeholder/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/popover/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/block-quotation/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/horizontal-rule/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/svg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/query-controls/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/radio-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/range-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/resizable-box/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/responsive-wrapper/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/sandbox/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/scroll-lock/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/select-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/shortcut/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/context.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/fill.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/slot.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/snackbar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/snackbar/list.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/spinner/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tab-panel/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/text-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/textarea-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tip/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toggle-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tooltip/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tree-select/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/ui/context/wordpress-component.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/visually-hidden/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/wordpress__components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "p-jackson",
        "sarayourfriend",
        "michaelhthomas",
        "manzoorwanijk",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__date",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__date/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__date/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__date/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__date/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__date/wordpress__date-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__deprecated",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__deprecated/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__deprecated/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__deprecated/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__deprecated/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__deprecated/wordpress__deprecated-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__dom",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__dom/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__dom/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__dom/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__dom/wordpress__dom-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__editor/components/autocompleters.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__editor/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__keycodes",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__keycodes/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__keycodes/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__keycodes/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__keycodes/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__keycodes/wordpress__keycodes-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__notices",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__notices/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__notices/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__notices/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__notices/store/actions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__notices/store/selectors.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__notices/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__notices/wordpress__notices-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "chihsuan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__plugins",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__plugins/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__plugins/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__plugins/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__plugins/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__plugins/wordpress__plugins-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__redux-routine",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__redux-routine/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__redux-routine/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__redux-routine/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__redux-routine/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__redux-routine/wordpress__redux-routine-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__rich-text",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__rich-text/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/wordpress__rich-text/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__rich-text/component/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/component/use-anchor-ref.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/component/use-anchor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/create.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__rich-text/store/actions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/store/selectors.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__rich-text/wordpress__rich-text-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2024-04-03T18:13:25.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "mikeybinns",
      "date": "2024-04-02T21:05:08.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "sarayourfriend",
      "date": "2024-04-02T19:46:59.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "gziolo",
      "date": "2024-03-26T12:06:26.000Z",
      "abbrOid": "af6acf8"
    }
  ],
  "mainBotCommentID": 2016509634,
  "ciResult": "pass"
}

typescript-bot · 2024-03-23T14:26:25Z

🔔 @dsifford @sirreal @dmsnell @tomasztunik @sunyatasattva @bastolen @p-jackson @sarayourfriend @michaelhthomas @manzoorwanijk @chihsuan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2024-03-23T19:27:44Z

@rafaucau The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

gziolo · 2024-03-26T11:09:08Z

Overall, great effort to use all the exposed types from the updated WordPress packages. There might be still a few smaller packages that could natively offer types without too much hassle.

rafaucau · 2024-03-28T19:24:26Z

It looks like the problem with component type detection (#69133 (comment)) is coming from my IDE.
PHPStorm:

VSCode:

Last time I had looked, the problem was also in the VSC, but today it is ok. In that case, I'll be continuing this PR using VSC.

mikeybinns · 2024-03-28T19:32:14Z

Okay, great, so just to confirm, the plan is now to update your PR to remove the deep imports and instead use React.ComponentProps to get the props for each component?

I saw you added me to your repo, were you looking for help with this @rafaucau? Or was that just for assistance with the bug you mentioned above?

rafaucau · 2024-03-28T21:30:47Z

@mikeybinns I saw you added me to your repo, were you looking for help with this @rafaucau? Or was that just for assistance with the bug you mentioned above?

Initially with bug mentioned above. But this has already been solved.

But there is one last challenge. Somehow the WPCompleter type has to be extracted so that it is possible to pass the generic like EditorInserterItem or User.

DefinitelyTyped/types/wordpress__editor/components/autocompleters.d.ts

Lines 1 to 6 in 145a12b

    
           import { EditorInserterItem } from "@wordpress/block-editor"; 
        
           import { WPCompleter } from "@wordpress/components/build-types/autocomplete/types"; 
        
           import { User } from "@wordpress/core-data"; 
        
           export const blockAutocompleter: WPCompleter<EditorInserterItem>; 
        
           export const userAutocompleter: WPCompleter<User>;

This is how I managed to extract the type of WPCompleter, but unfortunately then it is not possible to pass the generic:

type Completer = React.ComponentProps<typeof Autocomplete>['completers'][number];

I have no idea at this moment. Can you help?

typescript-bot · 2024-03-28T21:32:51Z

@sarayourfriend, @gziolo, @mikeybinns Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

mikeybinns · 2024-03-28T21:49:31Z

But there is one last challenge. Somehow the WPCompleter type has to be extracted so that it is possible to pass the generic like EditorInserterItem or User.

I don't think it's possible to both extract a type from an array and modify it with a generic, so for that one, you might need to just use that deep import 🤷 This is made clearer if you imagine the type was given a generic in its implemenation.

e.g.

type ThingWithGeneric<T> = {test: T};
type ArrayType = ThingWithGeneric<string>[]
type Test = ArrayType[number] // ThingWithGeneric<string>, string has already been passed to it.

sarayourfriend · 2024-04-02T19:45:45Z

I think it's a fine stop-gap to accept it will be WPCompleter<any> for now, and submit a PR to Gutenberg that turns the autocompleter component function into a generic so that this becomes possible.

import React from 'react'

type WPCompleter<T = any> = {
    name: T
}

type Props<T> = {
    completers: WPCompleter<T>[]
}

const Component = <T, >(props: Props<T>) => {
    return <div />
}

type Completer<T> = React.ComponentProps<typeof Component<T>>['completers'][number]

Here's the TS playground link to try it out

I haven't worked with React in almost three years, so I don't know whether React with TypeScript works well with these generic prop types (I seem to recall them being finicky).

typescript-bot · 2024-04-02T19:47:38Z

@gziolo, @mikeybinns Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

mikeybinns · 2024-04-02T20:02:46Z

I haven't worked with React in almost three years, so I don't know whether React with TypeScript works well with these generic prop types (I seem to recall them being finicky).

I think they work okay, I haven't had issues on my end, it's just a bit of uncommon syntax. I have a separate PR trying to add something similar for SelectControl, so I could make a PR for this too.

They may also make an exception for exporting the completer type, like they have done with IconType? I think best option may be submit an issue first explaining the issue and get their recommendation for their preferred fix :)

types/wordpress__block-editor/components/url-popover.d.ts

mikeybinns · 2024-04-02T20:17:29Z

types/wordpress__blocks/api/categories.d.ts

    slug: string;
    title: string;
-    icon?: JSX.Element | Dashicon.Icon | null | undefined;
+    icon?: JSX.Element | IconType | null | undefined;


IconType includes JSX.Element, so this can be simplified

peterblazejewicz · 2024-04-02T20:29:48Z

2c: I'd suggest splitting this one into two (removals stays, amendments goes into new PR via branch rename). It looks like removals are non controversial. Just an opinion

typescript-bot · 2024-04-02T21:06:13Z

@gziolo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

rafaucau · 2024-04-03T18:19:15Z

Ready to merge

mikeybinns · 2024-04-03T18:20:42Z

Good job @rafaucau 🥳

margolisj · 2024-04-06T04:39:17Z

Thanks @rafaucau and @mikeybinns. I appreciate all the typing!

rafaucau added 5 commits March 23, 2024 14:40

remove @wordpress/components

f5c18f3

remove @wordpress/plugins

8ae77c2

remove @wordpress/date

2e04d80

remove @wordpress/dom

f0a2213

remove @wordpress/notices

c54ae39

rafaucau mentioned this pull request Mar 23, 2024

fix(@wordpress/components): make Id prop optional in the BaseControl component #69130

Merged

rafaucau added 5 commits March 23, 2024 14:57

remove @wordpress/keycodes

f2e0fa1

remove @wordpress/rich-text

9fa3ba2

remove @wordpress/redux-routine

d19350a

remove @wordpress/block-serialization-default-parser

a128237

remove @wordpress/deprecated

3aa992d

rafaucau marked this pull request as ready for review March 23, 2024 14:25

typescript-bot added Edits Infrastructure Edits multiple packages Check Config Changes a module config files Huge Change labels Mar 23, 2024

rafaucau added 3 commits March 23, 2024 20:05

wordpress__block-editor: update imports

48f103f

wordpress__blocks: update imports

4b1e421

wordpress__editor: update imports

c652529

rafaucau changed the title ~~Remove @wordpress/* bundled types~~ Remove @wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated} bundled types Mar 23, 2024

typescript-bot added the The CI failed When GH Actions fails label Mar 23, 2024

rafaucau marked this pull request as draft March 23, 2024 19:33

rafaucau marked this pull request as ready for review March 23, 2024 19:33

rafaucau mentioned this pull request Mar 23, 2024

Add @wordpress/keycodes to allowedPackageJsonDependencies.txt microsoft/DefinitelyTyped-tools#983

Merged

retrigger checks

5fae553

use React.ComponentProps

145a12b

typescript-bot removed the Owner Approved A listed owner of this package signed off on the pull request. label Mar 28, 2024

use React.ComponentProps in one more place

ec36d38

rafaucau requested a review from sarayourfriend April 2, 2024 13:43

sarayourfriend approved these changes Apr 2, 2024

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 2, 2024

mikeybinns reviewed Apr 2, 2024

View reviewed changes

mikeybinns approved these changes Apr 2, 2024

View reviewed changes

typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 2, 2024

RyanCavanaugh approved these changes Apr 3, 2024

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 3, 2024

typescript-bot merged commit bac5f47 into DefinitelyTyped:master Apr 3, 2024

rafaucau deleted the remove/wp-bundled-types branch April 3, 2024 18:20

This was referenced Apr 8, 2024

[wordpress__edit-post] Use latest @wordpress/components types #69307

Closed

[wordpress__edit-post] Use latest @wordpress/components types #69308

Merged

Remove @wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated} types due to bundled definitions in packages #69133

Remove @wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated} types due to bundled definitions in packages #69133

Uh oh!

Conversation

rafaucau commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

13 packages in this PR (and infra files)

Code Reviews

Status

Uh oh!

typescript-bot commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 23, 2024

Uh oh!

gziolo commented Mar 26, 2024

Uh oh!

rafaucau commented Mar 28, 2024

Uh oh!

mikeybinns commented Mar 28, 2024

Uh oh!

rafaucau commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 28, 2024

Uh oh!

mikeybinns commented Mar 28, 2024

Uh oh!

sarayourfriend commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024

Uh oh!

mikeybinns commented Apr 2, 2024

Uh oh!

Uh oh!

mikeybinns Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

peterblazejewicz commented Apr 2, 2024

Uh oh!

typescript-bot commented Apr 2, 2024

Uh oh!

rafaucau commented Apr 3, 2024

Uh oh!

mikeybinns commented Apr 3, 2024

Uh oh!

margolisj commented Apr 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Remove `@wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated}` types due to bundled definitions in packages #69133

Remove `@wordpress/{components,plugins,date,dom,notices,keycodes,rich-text,redux-routine,block-serialization-default-parser,deprecated}` types due to bundled definitions in packages #69133

rafaucau commented Mar 23, 2024 •

edited

Loading

typescript-bot commented Mar 23, 2024 •

edited

Loading

typescript-bot commented Mar 23, 2024 •

edited

Loading

rafaucau commented Mar 28, 2024 •

edited

Loading