[react] Deprecate types that are related to the prop-types package
#69002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2024
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 7 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69002,
"author": "eps1lon",
"headCommitOid": "575b3a778985459b2191f7b185af999673a84002",
"mergeBaseOid": "b0e683d4a7c4aaa3df73b397dcaa4e80bea25cb6",
"lastPushDate": "2024-03-15T11:17:05.000Z",
"lastActivityDate": "2024-03-18T18:45:21.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "prop-types",
"kind": "edit",
"files": [
{
"path": "types/prop-types/index.d.ts",
"kind": "definition"
},
{
"path": "types/prop-types/prop-types-tests.ts",
"kind": "test"
}
],
"owners": [
"DovydasNavickas",
"ferdaber",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 2000567435,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Edits multiple packages
Author is Owner
Contributor
|
🔔 @DovydasNavickas @ferdaber @johnnyreilly @bbenezech @pzavolinsky @ericanderson @theruther4d @guilhermehubner @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
Collaborator
Author
|
Landing since nobody seems to have an issue with this. |
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 19 will ignore
.propTypeswhich means we no longer have any use for the types related to that.Turns out that we don't even need most of the related types since these are just aliases to
prop-typestypes. So if you use runtime validation withprop-typesand TypeScript, you can continue using the relevant types fromprop-typesinstead ofreact.To ease migration, I ported the
WeakValidationMaptype which was introduced in #31280.The following types are deprecated:
WeakValidationMapValidationMapRequireableValidatorReactPropTypesTo keep using these types, the following diff is required (can be handled with the
deprecated-react-prop-types-typescodemod):ReactPropTypesis deprecated without removal. You should pick the relevant validators fromPropTypesinstead.Migration away from the deprecated types within DT is illustrated in #69011 which I'll split out into one PR per package.