@leafac Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• busboy — on npm, on unpkg
  • owner-approval: @martin-badin

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 68985,
  "author": "leafac",
  "headCommitOid": "f4b0764fdaf2d68af9ca34ef670e9f60ec4422ca",
  "mergeBaseOid": "6c31c706695910736af0ee24a5724f3837bfcd9a",
  "lastPushDate": "2024-03-14T12:33:54.000Z",
  "lastActivityDate": "2024-05-02T10:08:15.000Z",
  "mergeOfferDate": "2024-05-02T07:41:54.000Z",
  "mergeRequestDate": "2024-05-02T10:08:15.000Z",
  "mergeRequestUser": "leafac",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "busboy",
      "kind": "edit",
      "files": [
        {
          "path": "types/busboy/busboy-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/busboy/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jacobbaskin",
        "BendingBender",
        "martin-badin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "martin-badin",
      "date": "2024-05-02T07:41:16.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1997352910,
  "ciResult": "pass"
}

🔔 @jacobbaskin @BendingBender @martin-badin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@leafac The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@leafac I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 13th (in a week) if the issues aren't addressed.

⏳ Hi @leafac,

It's been a few days since this PR was approved by martin-badin and we're waiting for you to fix the test failures and then for a maintainer approval.

If you would like to short-circuit another wait for a maintainer, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@leafac I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on May 6th (in a week) if the issues aren't addressed.

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @leafac.

(Ping @jacobbaskin, @BendingBender, @martin-badin.)

@leafac The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@leafac: Everything looks good here. I am ready to merge this PR (at f4b0764) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jacobbaskin, @BendingBender, @martin-badin: you can do this too.)

Ready to merge