[@types/react] Deprecate ReactComponentElement
#68463
Conversation
ghost
requested review from
Jessidhia,
eps1lon and
johnnyreilly
as code owners
|
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68463,
"author": "codershiba",
"headCommitOid": "a2f0a45ae7ac97a1fdc540f210cc629b6a5dfff8",
"mergeBaseOid": "8eef7f48da3124d97c81e44063de0b35729a9064",
"lastPushDate": "2024-02-03T13:27:55.000Z",
"lastActivityDate": "2024-02-27T09:05:09.000Z",
"mergeOfferDate": "2024-02-26T18:54:44.000Z",
"mergeRequestDate": "2024-02-27T09:05:09.000Z",
"mergeRequestUser": "codershiba",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "brainhubeu__react-carousel",
"kind": "edit",
"files": [
{
"path": "types/brainhubeu__react-carousel/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/brainhubeu__react-carousel/brainhubeu__react-carousel-tests.tsx",
"kind": "test"
},
{
"path": "types/brainhubeu__react-carousel/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jackall3n",
"sinchang",
"roberthebel"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-26T19:35:39.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-02-26T18:35:30.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "eps1lon",
"date": "2024-02-26T14:03:24.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1925322236,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
🔔 @jackall3n @sinchang @RobertHebel @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Where is GH Actions?
ghost
requested review from
Bartvds,
Diullei,
ElizabethSamuel-MSFT,
Igorbek,
Rick-Kirkham,
RyanCavanaugh,
andrewbranch,
borisyankov,
horiuchi,
mjbvz,
peterblazejewicz,
sandersn and
vvakame
as code owners
typescript-bot
added
Edits Infrastructure
Edits multiple packages
Too Many Owners
and removed
Untested Change
People who would have been pingedljharb darbio skarum StefH buggy wwwy3y3 OrthoDex MichaelMarner daniel-cottone kostya-misura coderbyheart palmithor daniloraisi simonbuchan Haydabase repl-chris aneilbaboo jeznag louislarry dpapukchiev ohookins trevor-leach jagregory dalen loikg skyzenr redlickigrzegorz juancarbonel pwmcintyre alex-bolenok-centralreach marianzange apepper apalumbo SachinShekhar ivanmartos zach-anthony savnik bboure jamesorlakin aphex joeykilpatrick lmanerich ryota-ka jineshshah36 peping mikhail-monchak cdoe kroustille MStoykov codebien oleiade olegbespalov ppcano nicolevanderhoeven ankur22 inancgumus ka3de joanlopez dobrud macobo dmytro-gokun LiamAttClarke life777 amxfonseca Nosfit mbullington pascaloliv mschilde bewithjonam lancegliser bengry doubutsunokarada Microsoft jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK hoo29 kjin ajafff islishude mwiktorczyk mohsen1 n-e galkin parambirs eps1lon ThomasdenH WilcoBakker samuela kuehlein bhongy chyzwar trivikr yoursunny qwelias ExE-Boss peterblazejewicz addaleax victorperin ZYSzys NodeJS LinusU wafuwafu13 mcollina Semigradsky johnnyreilly bbenezech pzavolinsky ericanderson DovydasNavickas theruther4d guilhermehubner ferdaber jrakotoharisoa hotell franklixuefei Jessidhia saranshkataria lukyth zieka dancerphil dimitropoulos disjukr vhfmag hellatan priyanshurav hassankhan JonathanWilbur a-pavlenko fredericbarthelet bryan-hunter thomasaribart G-Rath AbdullahAli fargito bacarybruno domazet93 sleeyax victorgveloso pauhull dsifford sirreal dmsnell |
typescript-bot
added
Untested Change
How about redeclaring the types in the package rather than importing it from react like |
|
Yeah that makes sense if that's the best migration path we can offer. But it needs to be documented in the PR. |
typescript-bot
added
the
Unreviewed
|
Re-ping @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav, @Semigradsky: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @codershiba. (Ping @jackall3n, @sinchang, @RobertHebel, @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav, @Semigradsky.) |
typescript-bot
added
Where is GH Actions?
|
@codershiba The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
typescript-bot
added
Check Config
|
@eps1lon do the latest changes satisfy your review feedback? |
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Makes sense to deprecate. I generally try to keep the utility types to a minimum to make learning React easier. This seems like a good candidate for removal considering it's only used in one other DT package.
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@codershiba: Everything looks good here. I am ready to merge this PR (at a2f0a45) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
5 participants
Closes #68457
Please fill in this template.
pnpm test react.If changing an existing definition:
package.json.