Skip to content

Formatted non-letter and recently changed types with dprint#66858

Merged
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:dprint-fmt-rest
Sep 27, 2023
Merged

Formatted non-letter and recently changed types with dprint#66858
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:dprint-fmt-rest

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Collaborator

👉 Partial implementation of #65993. If you're seeing this and are surprised it's happening, please read the discussion and give feedback! ❤️

Implements the dprint formatting changes on all remaining packages, excluding the ones added to the.dprint.jsonc's "excludes" in #66235. This captures two groups:

  • Packages whose names don't start with a letter
  • Packages that have had commits since their letter PR was merged

@DangerBotOSS
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

dcp-client (unpkg)

was missing the following properties:

  1. createConfigFragments
  2. initcb
  3. fetchSync

oracledb (unpkg)

was missing the following properties:

  1. AqDeqOptions
  2. AqEnqOptions
  3. AqMessage
  4. AqQueue
  5. BaseDbObject
as well as these 26 other properties...

Connection, Lob, Pool, PoolStatistics, ResultSet, SodaDatabase, SodaCollection, SodaDocCursor, SodaDocument, SodaOperation, DB_TYPE_LONG_NVARCHAR, STARTUP_MODE_DEFAULT, STARTUP_MODE_FORCE, STARTUP_MODE_RESTRICT, POOL_STATUS_RECONFIGURING, AQ_DEQ_MODE_REMOVE_NO_DATA, AQ_MSG_DELIV_MODE_PERSISTENT, TPC_BEGIN_JOIN, TPC_BEGIN_NEW, TPC_BEGIN_PROMOTE, TPC_BEGIN_RESUME, TPC_END_NORMAL, TPC_END_SUSPEND, ARRAY, OBJECT, lobPrefetchSize

Generated by 🚫 dangerJS against 04b1b23

@typescript-bot
Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

36 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66858,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "04b1b23051a07fe36b1b71658c3a95a4a3c83c3c",
  "mergeBaseOid": "3944f931c449b15dd670b42f8d4d582a70456957",
  "lastPushDate": "2023-09-27T16:22:46.000Z",
  "lastActivityDate": "2023-09-27T20:19:22.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "11ty__eleventy-img",
      "kind": "edit",
      "files": [
        {
          "path": "types/11ty__eleventy-img/11ty__eleventy-img-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/11ty__eleventy-img/generate-html.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/11ty__eleventy-img/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "NotWoods"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "3box",
      "kind": "edit",
      "files": [
        {
          "path": "types/3box/3box-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/3box/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "shikanime"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "7zip-min",
      "kind": "edit",
      "files": [
        {
          "path": "types/7zip-min/7zip-min-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Tanandara"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "alpinejs__morph",
      "kind": "edit",
      "files": [
        {
          "path": "types/alpinejs__morph/alpinejs__morph-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/alpinejs__morph/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ekwoka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "blazor__javascript-interop",
      "kind": "edit",
      "files": [
        {
          "path": "types/blazor__javascript-interop/blazor__javascript-interop-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "broccoli-funnel",
      "kind": "edit",
      "files": [
        {
          "path": "types/broccoli-funnel/broccoli-funnel-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/broccoli-funnel/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "KonradPerlicki"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "chai-arrays",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-arrays/chai-arrays-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "clementprevot"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "check-types",
      "kind": "edit",
      "files": [
        {
          "path": "types/check-types/check-types-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "idchlife",
        "shov"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "circomlibjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/circomlibjs/circomlibjs-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/circomlibjs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "cedoor",
        "vplasencia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "cli-progress",
      "kind": "edit",
      "files": [
        {
          "path": "types/cli-progress/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mhegazy",
        "alvaromartmart",
        "peterblazejewicz",
        "mschilde"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "compact-timezone-list",
      "kind": "edit",
      "files": [
        {
          "path": "types/compact-timezone-list/compact-timezone-list-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "buddhanag12"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "dcp-client",
      "kind": "edit",
      "files": [
        {
          "path": "types/dcp-client/wallet.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bryan-hoang",
        "BChristieDistributive",
        "fairushyn"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "draco3d",
      "kind": "edit",
      "files": [
        {
          "path": "types/draco3d/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "donmccurdy",
        "horizon0514"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "dxf",
      "kind": "edit",
      "files": [
        {
          "path": "types/dxf/dxf-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/dxf/toPolylines.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "prestonii"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "ember",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "jamescdavis",
        "wagenet",
        "gitKrystan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "for-each",
      "kind": "edit",
      "files": [
        {
          "path": "types/for-each/for-each-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/for-each/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "function.prototype.name",
      "kind": "edit",
      "files": [
        {
          "path": "types/function.prototype.name/function.prototype.name-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/function.prototype.name/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/function.prototype.name/polyfill.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/function.prototype.name/shim.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "git-log-parser",
      "kind": "edit",
      "files": [
        {
          "path": "types/git-log-parser/git-log-parser-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/git-log-parser/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "crutchcorn"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/google-apps-script.spreadsheet.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "PopGoesTheWza",
        "motemen",
        "pierluigi-montagna",
        "mtgto"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "google-publisher-tag",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-publisher-tag/google-publisher-tag-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/google-publisher-tag/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jimper",
        "zombifier",
        "taymonbeal"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "google.maps",
      "kind": "edit",
      "files": [
        {
          "path": "types/google.maps/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "amuramoto",
        "wangela"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "gorilla-engine",
      "kind": "edit",
      "files": [
        {
          "path": "types/gorilla-engine/gorilla-engine-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gorilla-engine/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jhwoodward",
        "UJAM-JH",
        "rip-off-hb",
        "pkellett",
        "vpietropaolo-ujam",
        "agachuma"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gsi",
      "kind": "edit",
      "files": [
        {
          "path": "types/gsi/gsi-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "aronhoyer"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "has-property-descriptors",
      "kind": "edit",
      "files": [
        {
          "path": "types/has-property-descriptors/has-property-descriptors-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/has-property-descriptors/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jquery",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery/JQueryStatic.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "borisyankov",
        "choffmeister",
        "Steve-Fenton",
        "Diullei",
        "tasoili",
        "seanski",
        "Guuz",
        "ksummerlin",
        "basarat",
        "nwolverson",
        "derekcicerone",
        "AndrewGaspar",
        "seikichi",
        "benjaminjackman",
        "JoshStrobl",
        "johnnyreilly",
        "DickvdBrink",
        "King2500",
        "terrymun",
        "martin-badin",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "maxmsp",
      "kind": "edit",
      "files": [
        {
          "path": "types/maxmsp/maxmsp-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "twhiston",
        "FrancescElies"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "navermaps",
      "kind": "edit",
      "files": [
        {
          "path": "types/navermaps/navermaps-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ckboyjiy",
        "DongKyuuuu",
        "fclemonschool",
        "suhwancha",
        "hig4342",
        "kkokkojeong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "object.groupby",
      "kind": "edit",
      "files": [
        {
          "path": "types/object.groupby/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/object.groupby/object.groupby-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "chilldriven",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oracledb/oracledb-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "ovenplayer",
      "kind": "edit",
      "files": [
        {
          "path": "types/ovenplayer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ovenplayer/ovenplayer-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "SangwonOh",
        "dygy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "tar-stream",
      "kind": "edit",
      "files": [
        {
          "path": "types/tar-stream/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tar-stream/tar-stream-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "glicht",
        "peterblazejewicz",
        "kevin-lindsay-1",
        "screendriver"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "telegram-web-app",
      "kind": "edit",
      "files": [
        {
          "path": "types/telegram-web-app/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/telegram-web-app/telegram-web-app-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "KnorpelSenf",
        "MKRhere",
        "deptyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "twig",
      "kind": "edit",
      "files": [
        {
          "path": "types/twig/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "soywiz",
        "enko",
        "mtizziani",
        "princefishthrower",
        "emmanuelgautier"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "zdog",
      "kind": "edit",
      "files": [
        {
          "path": "types/zdog/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "demensky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

⚠️ There are too many reviewers for this PR change (137). Merging can only be handled by a DT maintainer.

People who would have been pinged NotWoods shikanime Tanandara ekwoka peterblazejewicz KonradPerlicki clementprevot idchlife shov cedoor vplasencia mhegazy alvaromartmart mschilde buddhanag12 bryan-hoang BChristieDistributive fairushyn donmccurdy horizon0514 prestonii chriskrycho jamescdavis wagenet gitKrystan ljharb crutchcorn PopGoesTheWza motemen pierluigi-montagna mtgto jimper zombifier taymonbeal amuramoto wangela jhwoodward UJAM-JH rip-off-hb pkellett vpietropaolo-ujam agachuma aronhoyer leonard-thieu borisyankov choffmeister Steve-Fenton Diullei tasoili seanski Guuz ksummerlin basarat nwolverson derekcicerone AndrewGaspar seikichi benjaminjackman JoshStrobl johnnyreilly DickvdBrink King2500 terrymun martin-badin princefishthrower alejo90 atd-schubert mcauer ronikar life777 henrythasler captain-igloo someonewithpc twhiston FrancescElies ckboyjiy DongKyuuuu fclemonschool suhwancha hig4342 kkokkojeong Microsoft DefinitelyTyped jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK hoo29 kjin ajafff islishude mwiktorczyk mohsen1 n-e galkin parambirs eps1lon ThomasdenH WilcoBakker wwwy3y3 samuela kuehlein bhongy chyzwar trivikr yoursunny qwelias ExE-Boss addaleax victorperin ZYSzys NodeJS LinusU wafuwafu13 mcollina Semigradsky chilldriven connorjayfitzgerald dannyb648 SangwonOh dygy glicht kevin-lindsay-1 screendriver KnorpelSenf MKRhere deptyped soywiz enko mtizziani emmanuelgautier demensky

@johnnyreilly johnnyreilly merged commit d6df71f into DefinitelyTyped:master Sep 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the dprint-fmt-rest branch September 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants