Formatted mp4frag with dprint and removed node/buffer import#66834
Merged
johnnyreilly merged 2 commits intoDefinitelyTyped:masterfrom Sep 26, 2023
Merged
Conversation
JoshuaKGoldberg
changed the title
Contributor
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66834,
"author": "JoshuaKGoldberg",
"headCommitOid": "c75fa12503e91d7933555e07a4dcea5f2e7eecd5",
"mergeBaseOid": "afc9b20cd09fbc0aed0a52379796a723d5575c64",
"lastPushDate": "2023-09-26T14:24:58.000Z",
"lastActivityDate": "2023-09-26T14:38:58.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": ".dprint.jsonc",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "mp4frag",
"kind": "edit",
"files": [
{
"path": "types/mp4frag/index.d.ts",
"kind": "definition"
},
{
"path": "types/mp4frag/mp4frag-tests.ts",
"kind": "test"
}
],
"owners": [
"kensand"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"ciResult": "pass"
} |
Contributor
|
🔔 @kensand — please review this PR in the next few days. Be sure to explicitly select |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:
This PR is split out from #66534. Implements the dprint formatting changes on
mp4fragsince it was failing in CI. Specifically:That seems to have come from:
DefinitelyTyped/types/mp4frag/index.d.ts
Line 8 in ba980e2
No other types package still includes
import node/. I think the line can be removed.