Skip to content

Formatted types/z* packages with dprint #66547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg wants to merge 4 commits into from
Closed

Formatted types/z* packages with dprint #66547

JoshuaKGoldberg wants to merge 4 commits into from

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 30, 2023 •
edited
Loading

👉 Partial implementation of #65993. If you're seeing this and are surprised it's happening, please read the discussion and give feedback! ❤️

Implements the dprint formatting changes on packages whose names start with ``z. We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:

git checkout dprint-onboarding -- .dprint.jsonc
time npx dprint fmt "types/z*/**/*.t*"
# Formatted 73 files.
# npx dprint fmt "types/z*/**/*.t*"  2.20s user 0.52s system 155% cpu 1.755 total
rm .dprint.jsonc

microsoft/DefinitelyTyped-tools#719 is making it hard to investigate CI. Once it's through, more CI failures are likely to appear due to DefinitelyTyped-tools > feat: remove formatting rules rules from dtslint not being merged included in CI yet.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 30, 2023
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterblazejewicz peterblazejewicz Awaiting requested review from peterblazejewicz peterblazejewicz will be requested when the pull request is marked ready for review peterblazejewicz is a code owner

@Bartvds Bartvds Awaiting requested review from Bartvds Bartvds will be requested when the pull request is marked ready for review Bartvds is a code owner

@borisyankov borisyankov Awaiting requested review from borisyankov borisyankov will be requested when the pull request is marked ready for review borisyankov is a code owner

@sandersn sandersn Awaiting requested review from sandersn sandersn will be requested when the pull request is marked ready for review sandersn is a code owner

@orta orta Awaiting requested review from orta orta will be requested when the pull request is marked ready for review orta is a code owner

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh RyanCavanaugh will be requested when the pull request is marked ready for review RyanCavanaugh is a code owner

@Diullei Diullei Awaiting requested review from Diullei Diullei will be requested when the pull request is marked ready for review Diullei is a code owner

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly will be requested when the pull request is marked ready for review johnnyreilly is a code owner

@basarat basarat Awaiting requested review from basarat basarat will be requested when the pull request is marked ready for review basarat is a code owner

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser DanielRosenwasser will be requested when the pull request is marked ready for review DanielRosenwasser is a code owner

@vvakame vvakame Awaiting requested review from vvakame vvakame will be requested when the pull request is marked ready for review vvakame is a code owner

@horiuchi horiuchi Awaiting requested review from horiuchi horiuchi will be requested when the pull request is marked ready for review horiuchi is a code owner

@Igorbek Igorbek Awaiting requested review from Igorbek Igorbek will be requested when the pull request is marked ready for review Igorbek is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoshuaKGoldberg