Remove no-padding tslint rule which does not exist anymore#66514
Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom Aug 30, 2023
Merged
Conversation
mastrzyz
requested review from
Bartvds,
Diullei,
ElizabethSamuel-MSFT,
Igorbek,
Rick-Kirkham,
RyanCavanaugh,
basarat,
borisyankov,
horiuchi,
johnnyreilly,
nycdotnet,
octatone,
peterblazejewicz,
sandersn and
vvakame
as code owners
ElizabethSamuel-MSFT
approved these changes
Aug 29, 2023
Collaborator
ElizabethSamuel-MSFT
left a comment
ElizabethSamuel-MSFT
left a comment
There was a problem hiding this comment.
signed off for office-js* files
Rick-Kirkham
approved these changes
Aug 30, 2023
Contributor
|
CI failures are unrelated. |
sandersn
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test <package to test>.This is a followup PR from work done here to remove the
no-paddingtslint rule :microsoft/DefinitelyTyped-tools#699
Looks like no one actually ever enabled this rule in the first place?