[lodash-es] ran dprint fmt #66355
[lodash-es] ran dprint fmt #66355
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 18 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66355,
"author": "JoshuaKGoldberg",
"headCommitOid": "93261606f00a33050cda8255a8bd9ece35549bbd",
"mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
"lastPushDate": "2023-08-11T18:21:33.000Z",
"lastActivityDate": "2023-08-11T18:27:17.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "lodash-es",
"kind": "edit",
"files": [
{
"path": "types/lodash-es/array.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/collection.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/date.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/debounce.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/function.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/index.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/lang.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/lodash-es-tests.ts",
"kind": "test"
},
{
"path": "types/lodash-es/math.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/number.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/object.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/scripts/generate-modules.ts",
"kind": "test"
},
{
"path": "types/lodash-es/string.default.d.ts",
"kind": "definition"
},
{
"path": "types/lodash-es/util.default.d.ts",
"kind": "definition"
}
],
"owners": [
"stephenlautier",
"e-cloud"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1675194230,
"ciResult": "pass"
} |
|
🔔 @stephenlautier @e-cloud — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. lodash-es (unpkg)was missing the following properties:
as well as these 13 other properties...toIterator, toJSON, value, valueOf, wrapperAt, wrapperChain, wrapperCommit, wrapperLodash, wrapperNext, wrapperPlant, wrapperReverse, wrapperToIterator, wrapperValue |
typescript-bot
added
the
Unreviewed
|
Re-ping @stephenlautier, @e-cloud: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @JoshuaKGoldberg. (Ping @stephenlautier, @e-cloud.) |
|
These changes were merged as part of #66533. |
3 participants
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩